Skip to content

Try Slot & Fill pattern for rendering Editable formatting controls #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduth merged 4 commits into from
Apr 26, 2017
Merged

Try Slot & Fill pattern for rendering Editable formatting controls #507

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c54ee1b
Render Editable Toolbar controls using Slot & Fill pattern
aduth Apr 25, 2017
3d98287
Determine editor focus by incoming focus prop
aduth Apr 26, 2017
ea5a642
Set formats state only if changed
aduth Apr 26, 2017
0958fe8
Force focus on editor when toggling format
aduth Apr 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Set formats state only if changed
  • Loading branch information
@aduth
aduth committed Apr 26, 2017
commit ea5a642fc56988adffb36adc1673849bb3a53d9e
6 changes: 4 additions & 2 deletions blocks/components/editable/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* External dependencies
*/
import classnames from 'classnames';
import { last } from 'lodash';
import { last, isEqual } from 'lodash';
import { Parser as HtmlToReactParser } from 'html-to-react';
import { Fill } from 'react-slot-fill';

Expand Down Expand Up @@ -165,7 +165,9 @@ export default class Editable extends wp.element.Component {
return result;
}, {} );

this.setState( { formats } );
if ( ! isEqual( this.state.formats, formats ) ) {
this.setState( { formats } );
}
}

bindEditorNode( ref ) {
Expand Down