Conversation
|
My personal notes:
|
a72bc9c to
cee5a4d
Compare
|
Flaky tests detected in cee5a4d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5081049790
|
chad1008
left a comment
There was a problem hiding this comment.
Changes look good to me and the new styles are looking great in Storybook. I agree on the full-width separators, I think it looks a lot nicer that way, personally. I'm sure you'll want input from others who offered feedback initially but I say 🚀 🚢
If we're committed to the radix-style color scale there are guides for these details. But:
It probably doesn't need to hold up this PR, but it feels like something that we need to make a decision on sooner rather than later. |
Absolutely. IMO, the current color config that we have doesn't feel comprehensive and clear to apply. We often end up having to interpret it, fill in gaps and/or making exceptions because the color combinations don't quite work out. This definitely feels like a bigger task than the Also flagging #50971 which is partially related to this topic |
|
As discussed in person with @jameskoster , I will go ahead and merge this PR, and later work on updating the styles of this component to match the current look&feel of the legacy |
What?
Fixes #50910
Tweak the design of the new
DropdownMenucomponent following the feedback from #50910Why?
We want our components to look good and consistent with the rest of the editor UI
How?
Testing Instructions
Screenshots or screencast
trunk