Skip to content

Private actions and selectors: return stable references, expose to thunks #51051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsnajdr merged 6 commits into from
Jun 8, 2023
Merged

Private actions and selectors: return stable references, expose to thunks #51051

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
147e23d
Return stable references to private selectors and actions
jsnajdr May 29, 2023
35552b6
Expose unlocked private actions and selectors to thunks
jsnajdr May 29, 2023
6814331
Add tests for private registry selectors, including one failing test
noisysocks May 26, 2023
144fb05
Fix comment typo in createRegistrySelector
jsnajdr May 30, 2023
ba0246b
Private registry selectors test: register selectors before store inst…
jsnajdr May 30, 2023
3aa08c6
Pre-bind private selectors so that registry selectors are bound to re…
jsnajdr May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Private registry selectors test: register selectors before store inst… 
…antiation
  • Loading branch information
@jsnajdr
jsnajdr committed Jun 7, 2023
commit ba0246b3d368c3367e8fc55001bf11623f2484a0
10 changes: 5 additions & 5 deletions packages/data/src/test/privateAPIs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,32 +208,32 @@ describe( 'Private data APIs', () => {
const otherStore = createReduxStore( 'other', {
reducer: ( state = {} ) => state,
} );
registry.register( otherStore );
unlock( otherStore ).registerPrivateSelectors( {
getPrice: createRegistrySelector(
( select ) => () => select( groceryStore ).getPublicPrice()
),
} );
registry.register( otherStore );
const privateSelectors = unlock( registry.select( otherStore ) );
expect( privateSelectors.getPrice() ).toEqual( 1000 );
} );

it( 'should support calling a private registry selector from a public selector', () => {
const groceryStore = createStore();
const getPriceWithShipping = createRegistrySelector(
( select ) => () => select( groceryStore ).getPublicPrice() + 5
);
const store = createReduxStore( 'a', {
reducer: ( state = {} ) => state,
selectors: {
getPriceWithShippingAndTax: ( state ) =>
getPriceWithShipping( state ) * 1.1,
},
} );
registry.register( store );
const getPriceWithShipping = createRegistrySelector(
( select ) => () => select( groceryStore ).getPublicPrice() + 5
);
unlock( store ).registerPrivateSelectors( {
getPriceWithShipping,
} );
registry.register( store );
expect(
registry.select( store ).getPriceWithShippingAndTax()
).toEqual( 1105.5 );
Expand Down