Add gettext content when translating 'Header'. #51066
Conversation
priethor
added
[Type] Enhancement
| const defaultLabels = { | ||
| /* translators: accessibility text for the top bar landmark region. */ | ||
| header: __( 'Header' ), | ||
| header: _x( 'Header', 'header landmark area' ), |
There was a problem hiding this comment.
Hi @gonzomir thank you for this enhancement 👍 We are missing the import of the _x function in import { __ } from '@wordpress/i18n'; line 14, but other than that the PR looks good.
|
@jorgefilipecosta Sorry for taking me so long to add the requested changes, let me know if anything else is required. |
|
@gonzomir Thanks for the PR. From what I've researched, the word
As you can see, the word Are there any steps to actually check the problem being proposed this time? |
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
It seems like this PR is better than what we had on trunk and adds some context, so I'm going to merge it.
4 participants
Fixes #51063.
What?
Use _x() with appropriate context when translating the word 'Header'.
Why?
The word 'Header' appears in different context in both Gutenberg and core, which makes it hard to translate.
How?
Add context to translatable strings when the context requires different translations.
Testing Instructions
Not sure about that, couldn't find information on how Gutenberg translation files are generated.