Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions packages/data/src/redux-store/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,18 @@ export default function createReduxStore( key, options ) {
},
store
);

let resolvers;
if ( options.resolvers ) {
resolvers = mapResolvers( options.resolvers );
selectors = mapSelectorsWithResolvers(
selectors,
resolvers,
store,
resolversCache
);
}

lock(
selectors,
new Proxy( privateSelectors, {
Expand All @@ -235,17 +247,6 @@ export default function createReduxStore( key, options ) {
} )
);

let resolvers;
if ( options.resolvers ) {
resolvers = mapResolvers( options.resolvers );
selectors = mapSelectorsWithResolvers(
selectors,
resolvers,
store,
resolversCache
);
}

const resolveSelectors = mapResolveSelectors( selectors, store );
const suspendSelectors = mapSuspendSelectors( selectors, store );

Expand Down
31 changes: 31 additions & 0 deletions packages/data/src/test/privateAPIs.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,37 @@ describe( 'Private data APIs', () => {
);
} );

it( 'should support combination of private selectors and resolvers', async () => {
const testStore = createReduxStore( 'test', {
reducer: ( state = {}, action ) => {
if ( action.type === 'RECEIVE' ) {
return { ...state, [ action.key ]: action.value };
}
return state;
},
selectors: {
get: ( state, key ) => state[ key ],
},
resolvers: {
get:
( key ) =>
async ( { dispatch } ) => {
const value = await ( 'resolved-' + key );
dispatch( { type: 'RECEIVE', key, value } );
},
},
} );
unlock( testStore ).registerPrivateSelectors( {
peek: ( state, key ) => state[ key ],
} );
registry.register( testStore );

await registry.resolveSelect( testStore ).get( 'x' );
expect( unlock( registry.select( testStore ) ).peek( 'x' ) ).toBe(
'resolved-x'
);
} );

it( 'should give private selectors access to the state', () => {
const groceryStore = createStore();
unlock( groceryStore ).registerPrivateSelectors( {
Expand Down