Bump Stylelint dependencies to latest v14.x compatible releases #51192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2.68 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
ntwb
changed the title
stylelint-config-recommended & stylelint-config-recommended-scss to v12
ntwb
changed the title
|
Flaky tests detected in 9605df5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5154116050
|
1 task
Member
|
There is now another more up-to-date PR from @mikeybinns that is fully functional, ready for review and testing: Thank you so much for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Bumps
stylelintfrom v14.2 to v14.16.1Bumps
stylelint-config-recommendedfrom v6.0.0 to v9.0.0Bumps
stylelint-config-recommended-scssfrom v5.0.2 to v8.0.0Dependencies changes remove
^semver caret, because Lerna is not a fan of installing specific versions, it's moot as each of these dependency bumps are the latest andlast releases in each of these major versions of each packageWhy?
With the Gutenberg project blocked from using Stylelint v15 because of the removal of "stylistic" rules this PR seeks to update Stylelint dependencies to latest compatible with Stylelint v14
How?
Packages were updated using the guide here: https://github.com/WordPress/gutenberg/blob/trunk/packages/README.md
Each package was first removed from each package from the
dependenciessection of the packagepackage.jsonfileEach package upgrade was then added using Lerna v5.x
lerna add stylelint-config-recommended@9 packages/stylelint-config/lerna add stylelint-config-recommended-scss@8 packages/stylelint-config/lerna add [email protected] packages/scripts/Testing Instructions
bump-stylelint-config-recommended-packagesbranchnpm installnpm run buildnpm run lint:cssTesting Instructions for Keyboard
Screenshots or screencast
Notes
See this issue comment in relation to why Stylelint is not being bumped to v15 at this stage #50336 (comment)
CI Failures
TypeError [ERR_INVALID_URL_SCHEME]: The URL must be of scheme fileissue