Skip to content

Popover: Allow legitimate 0 positions to update popover position #51320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 5 commits into from
Jun 12, 2023
Merged

Popover: Allow legitimate 0 positions to update popover position #51320

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ea42d0
Popover: Allow legitmate 0 positions to update popover position
andrewserong Jun 8, 2023
f81f2ad
Add changelog entry
andrewserong Jun 8, 2023
86fb707
Refactor to utility function
ciampo Jun 8, 2023
50475b5
Add unit tests
ciampo Jun 8, 2023
463041f
Switch to undefined fallback for null and NaN cases, update snapshots
andrewserong Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add changelog entry
  • Loading branch information
@andrewserong
andrewserong committed Jun 8, 2023
commit f81f2ad6a9064024222c09c9f7d3bfaeb6941006
4 changes: 4 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Bug Fix

- `Popover`: Allow legitimate 0 positions to update popover position ([#51320](https://github.com/WordPress/gutenberg/pull/51320)).

## 25.1.0 (2023-06-07)

### Enhancements
Expand Down