Fixed a bug in paragraph affecting content writing when block is left/right aligned. #5135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s left/right aligned. Classes alignright and alignleft were being passed to paragraph RichText, these classes contain CSS that make the cursor invisible when the paragraph is empty making content writing impossible.
jorgefilipecosta
added
the
[Type] Bug
Member
|
Looks like this might have been introduced originally to add support for wide and full alignment to paragraphs? Doesn't appear to currently be possible, but there's still some lingering references to |
Member
|
Wait.. the wide/full alignment does still exist, but only in the sidebar inspector? |
aduth
approved these changes
Feb 19, 2018
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Okay, I'm now less hopelessly confused about what's going on between the text alignment and block alignment, and can confirm this works as expected 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classes alignright and alignleft were being passed to paragraph RichText, these classes contain CSS that makes the cursor invisible when the paragraph is empty making content writing impossible.
Before
Add a post with an empty paragraph, use Block Alignment setting in inspector controls and choose left or right alignments. See it is impossible to write any content in the paragraph when it is left/right aligned and the cursor is never visible.
How Has This Been Tested?
Verify the behavior described above is fixed and paragraph works as expected.