Skip to content

Remove value syncing in Link Control #51387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getdave merged 5 commits into from
Oct 9, 2023
Merged

Remove value syncing in Link Control #51387

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b8e606
Remove the syncing
getdave Jun 9, 2023
b9c1b16
Update docs with best practices
getdave Jul 27, 2023
263d848
Remove unnecessary test coverage
getdave Jul 27, 2023
82aeb6f
Implement suggestion sync with previous state
getdave Sep 21, 2023
1e9288f
Apply update from Code Review
getdave Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unnecessary test coverage
  • Loading branch information
@getdave
getdave committed Oct 5, 2023
commit 263d848e2416b620577de16667e857f645a0e911
42 changes: 0 additions & 42 deletions packages/block-editor/src/components/link-control/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2509,48 +2509,6 @@ describe( 'Controlling link title text', () => {
screen.queryByRole( 'textbox', { name: 'Text' } )
).not.toBeInTheDocument();
} );

it( 'should reset state upon controlled value change', async () => {
const user = userEvent.setup();
const textValue = 'My new text value';
const mockOnChange = jest.fn();

const { rerender } = render(
<LinkControl
value={ selectedLink }
forceIsEditingLink
hasTextControl
onChange={ mockOnChange }
/>
);

await toggleSettingsDrawer( user );

const textInput = screen.queryByRole( 'textbox', { name: 'Text' } );

expect( textInput ).toBeVisible();

await user.clear( textInput );
await user.keyboard( textValue );

// Was originally title: 'Hello Page', but we've changed it.
rerender(
<LinkControl
value={ {
...selectedLink,
title: 'Something else',
} }
forceIsEditingLink
hasTextControl
onChange={ mockOnChange }
/>
);

// The text input should not be showing as the form is submitted.
expect( screen.queryByRole( 'textbox', { name: 'Text' } ) ).toHaveValue(
'Something else'
);
} );
} );

function getSettingsDrawerToggle() {
Expand Down