Block Editor: Improve data selector for BlockQuickNavigationItem #51429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
Mamaduka
commented
Jun 12, 2023
|
|
||
| return ( | ||
| <Button | ||
| key={ clientId } |
|
Size Change: +8 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
alexstine
approved these changes
Jun 12, 2023
Contributor
alexstine
left a comment
alexstine
left a comment
There was a problem hiding this comment.
Code looks clean but you should probably get one further review.
|
Flaky tests detected in 9adce28. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5247674975
|
Member
Author
|
Thank you, @alexstine! @noisysocks, I added the screencast to highlight the difference better. |
Member
|
Nice 🎉 |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…dPress#51429) * Block Editor: Improve data selector for BlockQuickNavigationItem * Remove unnecessary 'key' prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #51281.
PR updates the selector in
BlockQuickNavigationItemto only return data needed for rendering.Why?
The block attributes change often, and not every block has special handlers for the label. Returning the block name from the
mapSelectwill prevent unwanted rerenders.How?
__experimentalGetBlockLabelinside the selector.getBlockTypeselector.keyprop for the button.Testing Instructions
Screenshots or screencast
Before
CleanShot.2023-06-13.at.08.39.25.mp4
After
CleanShot.2023-06-13.at.08.41.20.mp4