Color Panel: Fix rendering of tabs with no color #51498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
force-pushed
the
fix/color-panel-empty-tab
branch
from
d68518f to
396d22a
Compare
t-hamano
added
Global Styles
t-hamano
changed the title
Contributor
Author
|
|
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
t-hamano
force-pushed
the
fix/color-panel-empty-tab
branch
from
396d22a to
f54aab2
Compare
andrewserong
approved these changes
Jun 15, 2023
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
This is testing nicely for me, thank you for including the easy copy + paste theme.json snippets for each of the permutations, very thorough! 🙇
LGTM ✨
andrewserong
added
the
[Type] Bug
Contributor
Author
|
Thanks for the review, @andrewserong! |
Member
|
Thanks @t-hamano 🙌 |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #50267
Might be related to: #48893
What?
This PR fixes a problem in the ColorPanel component where Background or Gradient tabs are rendered even when there is no color available.
Why?
When adding the tabs to be displayed to the
tabsproperty array, there appears to be no check to see if they have available colors.How?
Check to see if it actually has available colors, as it does when generating element-level tabs.
Testing Instructions
Enable Emptytheme and update
theme.jsonas follows in each case, cnfirm that the expected results are obtained.Disable all gradient panels
No tabs should exist, only the background panel should appear in all color panels.
theme.json
{ "$schema": "https://schemas.wp.org/trunk/theme.json", "version": 2, "settings": { "appearanceTools": true, "color": { "customGradient": false, "defaultGradients": false, "gradients": [] } } }Disable all background panels
No tabs should exist, only solid gradient panel should appear in all color panels.
theme.json
Disable paragraph block gradient panel
Only for paragraph blocks, there should be no tabs, only background panel
theme.json
{ "$schema": "https://schemas.wp.org/trunk/theme.json", "version": 2, "settings": { "appearanceTools": true, "blocks": { "core/paragraph": { "color": { "customGradient": false, "defaultGradients": false, "gradients": [] } } } } }Disable paragraph block background panel
Only for paragraph blocks, there should be no tabs, only gradient panel
theme.json
{ "$schema": "https://schemas.wp.org/trunk/theme.json", "version": 2, "settings": { "appearanceTools": true, "blocks": { "core/paragraph": { "color": { "defaultPalette": false, "custom": false, "palette": [] } } } } }Disable all gradient panels except the paragraph block
Except for the paragraph block, it should have no tabs, only background panel
theme.json
{ "$schema": "https://schemas.wp.org/trunk/theme.json", "version": 2, "settings": { "appearanceTools": true, "color": { "customGradient": false, "defaultGradients": false, "gradients": [] }, "blocks": { "core/paragraph": { "color": { "customGradient": true, "defaultGradients": true } } } } }Disable all background panels except the paragraph block
Except for the paragraph block, it should have no tabs, only gradient panel
theme.json
{ "$schema": "https://schemas.wp.org/trunk/theme.json", "version": 2, "settings": { "appearanceTools": true, "color": { "defaultPalette": false, "custom": false, "palette": [] }, "blocks": { "core/paragraph": { "color": { "defaultPalette": true, "custom": true } } } } }