Improve LinkControl Edit UI#51712

Merged

priethor merged 33 commits intotrunkfrom

tweak/link-control-edit-ui

Jun 26, 2023

Commits on Jun 26, 2023

Move text above link

richtabor
authored and
getdave
committed
Change "URL" label to "Link"

richtabor
authored and
getdave
committed
Style tweaks

richtabor
authored and
getdave
committed
Add chevron based advanced settings button

richtabor
authored and
getdave
committed
Adapt logic for rendering actions and settings

richtabor
authored and
getdave
committed
Tweaks

richtabor
authored and
getdave
committed
Add proper i18n

authored and
getdave
committed
Remove commented out style

authored and
getdave
committed
Use $button-size-next-default-40px

richtabor
authored and
getdave
committed
Add showSettings, combine with new logic

richtabor
authored and
getdave
committed
Add additional translation context to advanced

richtabor
authored and
getdave
committed
Update toggle drawer name in tests
getdave
committed
Standardise query for settings toggle
getdave
committed
Update test to check for absence of cancel button during link creation
getdave
committed
Fix cancellation tests
getdave
committed
Ensure label is always “Link” but remains hidden when it’s the only visible control
getdave
committed
Update tests to look for “Link” instead of “URL” name for input
getdave
committed
Update empty value UI tests to only run for editing as opposed to creating links
getdave
committed
Fix e2e test tabbing order
getdave
committed
Use updated terms
getdave
committed
Select settings toggle by text not aria label
getdave
committed
Fix another tabbing order bug
getdave
committed
Fix one more tabbing issue in e2e tests
getdave
committed
Fix final tab ordering e2e test
getdave
committed
Decouple conditions for showing action buttons from settings
getdave
committed
Tweak styling to account for action buttons when there are no settings provided
getdave
committed
Fix test
getdave
committed
Fix e2e test

scruffian
authored and
getdave
committed
Update name of the combobox

scruffian
authored and
getdave
committed
Fix test expecting Submit button on creation
getdave
committed
Fix test by testing under edit rather than creation conditions
getdave
committed
Rename URL to Link and avoid triggering command centre
getdave
committed
move test earlier
scruffian
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve LinkControl Edit UI#51712

Improve LinkControl Edit UI#51712
priethor merged 33 commits intotrunkfrom
tweak/link-control-edit-ui

Commits on Jun 26, 2023

Move text above link

Change "URL" label to "Link"

Style tweaks

Add chevron based advanced settings button

Adapt logic for rendering actions and settings

Tweaks

Add proper i18n

Remove commented out style

Use $button-size-next-default-40px

Add showSettings, combine with new logic

Add additional translation context to advanced

Update toggle drawer name in tests

Standardise query for settings toggle

Update test to check for absence of cancel button during link creation

Fix cancellation tests

Ensure label is always “Link” but remains hidden when it’s the only visible control

Update tests to look for “Link” instead of “URL” name for input

Update empty value UI tests to only run for editing as opposed to creating links

Fix e2e test tabbing order

Use updated terms

Select settings toggle by text not aria label

Fix another tabbing order bug

Fix one more tabbing issue in e2e tests

Fix final tab ordering e2e test

Decouple conditions for showing action buttons from settings

Tweak styling to account for action buttons when there are no settings provided

Fix test

Fix e2e test

Update name of the combobox

Fix test expecting Submit button on creation

Fix test by testing under edit rather than creation conditions

Rename URL to Link and avoid triggering command centre

move test earlier