Skip to content

Patterns: add a hint about the rename of reusable blocks to menu and inserter #51771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glendaviesnz merged 7 commits into from
Jul 5, 2023
Merged

Patterns: add a hint about the rename of reusable blocks to menu and inserter #51771

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ceca4e
update menus
glendaviesnz Jul 4, 2023
602909e
Update text
glendaviesnz Jul 4, 2023
919461b
Update toggle help text
glendaviesnz Jun 22, 2023
3045b10
Add a dismissible hint about the rename instead of changing menu labe…
glendaviesnz Jun 23, 2023
34461d4
try renaming menu instead of using notice
glendaviesnz Jul 5, 2023
e11f7a0
Fix e2e tests
glendaviesnz Jul 5, 2023
2c6a34a
reusable block hint spacing
SaxonF Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
reusable block hint spacing
  • Loading branch information
@SaxonF @glendaviesnz
SaxonF authored and glendaviesnz committed Jul 5, 2023
commit 2c6a34afb2ca5d5519c94b4e970133de952e1531
2 changes: 1 addition & 1 deletion packages/block-editor/src/components/inserter/reusable-block-rename-hint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export default function ReusableBlocksRenameHint() {
<div ref={ ref } className="reusable-blocks-menu-items__rename-hint">
<div className="reusable-blocks-menu-items__rename-hint-content">
{ __(
'Reusable blocks are now called "patterns". A "synced" pattern will behave in exactly the same way as a reusable block.'
'Reusable blocks are now called patterns. A synced pattern will behave in exactly the same way as a reusable block.'
) }
</div>
<Button
Expand Down
4 changes: 3 additions & 1 deletion packages/block-editor/src/components/inserter/reusable-blocks-tab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ function ReusableBlocksList( { onHover, onInsert, rootClientId } ) {
export function ReusableBlocksTab( { rootClientId, onInsert, onHover } ) {
return (
<>
<ReusableBlocksRenameHint />
<div className="block-editor-inserter__hint">
<ReusableBlocksRenameHint />
</div>
<ReusableBlocksList
onHover={ onHover }
onInsert={ onInsert }
Expand Down
5 changes: 4 additions & 1 deletion packages/block-editor/src/components/inserter/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,14 +712,17 @@ $block-inserter-tabs-height: 44px;
}
}

.block-editor-inserter__hint {
margin: $grid-unit-20 $grid-unit-20 0;
}

.reusable-blocks-menu-items__rename-hint {
align-items: top;
background: $gray-100;
border-radius: $radius-block-ui;
color: $gray-900;
display: flex;
flex-direction: row;
margin: $grid-unit-20 $grid-unit-20 $grid-unit-20 $grid-unit-20;
max-width: 380px;
}

Expand Down
2 changes: 1 addition & 1 deletion ...eusable-blocks/src/components/reusable-blocks-menu-items/reusable-block-convert-button.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ export default function ReusableBlockConvertButton( {
onClose();
} }
>
<ReusableBlocksRenameHint />
<VStack spacing="5">
<ReusableBlocksRenameHint />
<TextControl
__nextHasNoMarginBottom
label={ __( 'Name' ) }
Expand Down