Skip to content

Button: Introduce size prop #51842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mirka merged 12 commits into from
Jun 23, 2023
Merged

Button: Introduce size prop #51842

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
b992cbe
Revert "Button: Add opt-in prop for larger `isSmall` size (#51012)"
mirka Jun 22, 2023
5f1f4a8
Add docs for `size` prop
mirka Jun 22, 2023
82cff38
Add CSS
mirka Jun 23, 2023
5446c80
Fixup
mirka Jun 23, 2023
9f703d6
Add TODO for deprecation
mirka Jun 23, 2023
ae12f01
Add test for back compat
mirka Jun 23, 2023
400a02b
Fixup
mirka Jun 23, 2023
ccbd9da
Add changelog
mirka Jun 23, 2023
47bc0ea
Tweak description for "compact"
mirka Jun 23, 2023
d03ba97
Note that the `size` prop takes precedence
mirka Jun 23, 2023
9ec488a
Add test for prop priority
mirka Jun 23, 2023
590964c
Stop leaking `spinButtonSize` prop for styling
mirka Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixup
  • Loading branch information
@mirka
mirka committed Jun 23, 2023
commit 400a02b494123f2bf2e2fe67242ae5ab9b8a73c8
2 changes: 1 addition & 1 deletion packages/components/src/button/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function useDeprecatedProps( {
let computedVariant = variant;

if ( isSmall ) {
computedSize = 'small';
computedSize ??= 'small';
}

if ( isPrimary ) {
Expand Down