-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Switch performance tests to Playwright #52022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
a88918c
Run with Playwright in CI
WunderBart 4ce6571
Print stdout on error
WunderBart f6d9851
Run build:packages to use e2e utils
WunderBart 6fde09d
Extend timeout for the canvas spinner
WunderBart 6f28c60
Add missing front end perf report
WunderBart b9b0440
Remove obsolete step
WunderBart ea6891f
Make the typing testing consistent
WunderBart aeae2ec
Improve post editor perf testing consistency
WunderBart 309b9a2
Do not report slow tests
WunderBart b47d2b7
Use the same methodology for measuring post and site editors metrics
WunderBart 0427a37
Make the results table transformer more readable
WunderBart 542456e
Streamline the results processing p.1
WunderBart c06ab19
Improve visual step separation a tad :)
WunderBart df1216e
First step to separate metrics from the runner
WunderBart 2e13186
Define the results file suffix
WunderBart ed1e0cc
Merge remote-tracking branch 'origin' into refactor/playwright-perfor…
WunderBart fecc1a0
cosmetic
WunderBart 4a394d8
Fix matching pattern typo
WunderBart 647ea57
Make performance.js comparison runner results-agnostic
WunderBart 1a18006
Fix results handling
WunderBart f03e671
Use Playwright's attachments API to handle results
WunderBart 5db75c3
Upload raw results as well
WunderBart da43808
Be consistent with calc utils
WunderBart 00f641d
Streamline results handling
WunderBart 2b9a5ac
Use the same sampling convention for front-end metrics
WunderBart 1f8ecd1
Fix the metrics output in perf runner
WunderBart d649aac
tmp: compare performance with base branch
WunderBart ae40542
tmp: compare performance with base branch (run 2)
WunderBart 18fe132
tmp: compare performance with base branch (run 3)
WunderBart 8f15066
Revert "tmp: compare performance with base branch"
WunderBart b1d7f83
Remove unused code and do the switch
WunderBart e37cbc2
Merge remote-tracking branch 'origin' into refactor/playwright-perfor…
WunderBart 2c305da
Fix site editor typing spec
WunderBart c9c625e
Merge remote-tracking branch 'origin' into refactor/playwright-perfor…
WunderBart bbae249
Add inline comment
WunderBart 894896b
Expain why we need larger timeout for site editor visit util
WunderBart 7ac254e
Use dirent for getting files from dir
WunderBart 84bb262
Do not use the browser.newPage shortcut
WunderBart 182fbc1
Merge remote-tracking branch 'origin' into refactor/playwright-perfor…
WunderBart 1cf298a
Use trace buffer instead of tmp file
WunderBart f787f1e
Merge remote-tracking branch 'origin' into refactor/playwright-perfor…
WunderBart 5a68bbc
Fix 'unterminated string' error
WunderBart d0d81fb
Fix 'unterminated string' error p.2
WunderBart 37ef946
Make sure sanitized branch name is used for reading results json
WunderBart 127b21e
Merge remote-tracking branch 'origin' into refactor/playwright-perfor…
WunderBart 568d9d7
Prevent logging in via test.use() instead of creating new context
WunderBart File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make the typing testing consistent
- Loading branch information
commit ea6891fc08d3d0a3769fc2f9f1d43329f4021196
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.