Skip to content

TabPanel: implement Ariakit internally #52133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chad1008 merged 30 commits into from
Aug 2, 2023
Merged

TabPanel: implement Ariakit internally #52133

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
f20e989
Add Ariakit-powered version of TabPanel
chad1008 Jun 15, 2023
8b002ae
Copy `TabPanel` stories over to `Tabs`
chad1008 Jun 15, 2023
3f9b7e0
Add updated versions of `TabPanel` unit tests
chad1008 Jun 15, 2023
97a4edc
add "Manual Activation" story
chad1008 Jun 19, 2023
bbac641
switch to async/findby based unit testing
chad1008 Jun 28, 2023
3795477
update changelog
chad1008 Jun 29, 2023
5ede3dc
remove old radix dependency
chad1008 Jul 5, 2023
1bab116
rename monolithic component to `TabPanel` for consistency
chad1008 Jul 5, 2023
75f090c
add `useInstanceId` support
chad1008 Jul 6, 2023
ea1e21e
add className and id parity with existing component
chad1008 Jul 6, 2023
dac69b7
update setSelectedId helper
chad1008 Jul 6, 2023
e7b0aa2
apply Ariakit internals to existing TabPanel component
chad1008 Jul 6, 2023
6195305
update TabPanel unit tests to work with Ariakit internals
chad1008 Jul 6, 2023
68fcf7e
remove temporary separate/new component files
chad1008 Jul 12, 2023
b9e019c
Update packages/components/src/tab-panel/stories/index.tsx
chad1008 Jul 13, 2023
37c014b
update CHANGELOG entry
chad1008 Jul 13, 2023
c89aedd
restore package-lock.json
chad1008 Jul 13, 2023
582afa5
remove unnecessary `await`s
chad1008 Jul 13, 2023
c97cbee
move `extractTabName` out of component
chad1008 Jul 13, 2023
00d2eaa
restore original component lazy loading
chad1008 Jul 24, 2023
4b7d7bb
update CHANGELOG entry
chad1008 Jul 24, 2023
aa1bfc2
up editor preferences modal unit tests
chad1008 Jul 24, 2023
defdb27
merge trunk into add/ariakit-tabs
chad1008 Jul 25, 2023
9731da4
remove onSelect call count assertions in unit test
chad1008 Jul 26, 2023
9507f4f
update snapshot and add a component-level test to ensure proper tabin…
chad1008 Jul 26, 2023
d938bd3
merge trunk into add/ariakit-tabs
chad1008 Jul 26, 2023
60c70d5
merge trunk into add/ariakit-tabs
chad1008 Aug 2, 2023
6b98f0a
revert accidental change from `classnames` to `cx`
chad1008 Aug 2, 2023
1782f26
Update CHANGELOG entry
chad1008 Aug 2, 2023
4924d02
remove unneeded `key`
chad1008 Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update changelog
  • Loading branch information
@chad1008
chad1008 committed Jul 25, 2023
commit 379547766fd8eb0005ea7ee1173818174965268d
4 changes: 4 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@
- `ItemGroup`: Update button focus state styles to be inline with other button focus states in the editor. ([#51576](https://github.com/WordPress/gutenberg/pull/51576)).
- `ItemGroup`: Update button focus state styles to target `:focus-visible` rather than `:focus`. ([#51787](https://github.com/WordPress/gutenberg/pull/51787)).

### Experimental

- `Tabs`: Create a new version of `TabPanel` with updated internals, while maintaining the same functionality and API surface ([#52133](https://github.com/WordPress/gutenberg/pull/52133)).

### Bug Fix

- `Popover`: Allow legitimate 0 positions to update popover position ([#51320](https://github.com/WordPress/gutenberg/pull/51320)).
Expand Down