Skip to content

Navigation submenu: remove unused doc block #52152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ramonjd merged 1 commit into from
Jun 30, 2023
Merged

Navigation submenu: remove unused doc block #52152

ramonjd merged 1 commit into from
Jun 30, 2023

Conversation

@ramonjd
Copy link
Member

@ramonjd ramonjd commented Jun 30, 2023 •
edited
Loading

What?

Removed unused doc block in navigation submenu

Why?

block_core_navigation_submenu_build_css_colors was removed in https:/github.com//pull/48936

The doc block wasn't.

How?

The delete key.

Testing Instructions

Check I'm not dreaming and that the doc block actually describes a deleted function.

@ramonjd ramonjd added [Type] Task Issues or PRs that have been broken down into an individual action to take [Block] Navigation Affects the Navigation Block labels Jun 30, 2023
@ramonjd ramonjd requested a review from tellthemachines as a code owner June 30, 2023 05:14
@ramonjd ramonjd self-assigned this Jun 30, 2023
@github-actions
Copy link

github-actions bot commented Jun 30, 2023 •
edited
Loading

Flaky tests detected in 948ac38.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5419539241
📝 Reported issues:

@ramonjd ramonjd enabled auto-merge (squash) June 30, 2023 06:15
@ramonjd ramonjd disabled auto-merge June 30, 2023 06:48
@ramonjd ramonjd merged commit 5d2fd62 into trunk Jun 30, 2023
@ramonjd ramonjd deleted the remove/nav-submenu-php-comment branch June 30, 2023 06:48
@github-actions github-actions bot added this to the Gutenberg 16.2 milestone Jun 30, 2023
@ramonjd ramonjd mentioned this pull request Jun 30, 2023
Merged
@manooweb manooweb mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@talldan talldan talldan approved these changes

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

Assignees

@ramonjd ramonjd

Labels

[Block] Navigation Affects the Navigation Block [Type] Task Issues or PRs that have been broken down into an individual action to take

Projects

None yet

Milestone

Gutenberg 16.2

Development

Successfully merging this pull request may close these issues.

3 participants

@ramonjd @talldan