Make use of accessing private APIs from thunks directly #52214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +26 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in e9eddaa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5505756637
|
youknowriad
approved these changes
Jul 7, 2023
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
This looks good to me.
jsnajdr
force-pushed
the
update/access-private-apis-from-thunks
branch
from
ddedead to
13bc185
Compare
Contributor
|
weird these e2e test failures, are they related? |
Member
Author
They refuse to go away, even after rebase, after restarting... They might have a point, I'll investigate that. |
jsnajdr
force-pushed
the
update/access-private-apis-from-thunks
branch
from
13bc185 to
e9eddaa
Compare
Member
Author
|
It turns out that I forgot to actually register the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #51051, private selectors and actions are exposed to thunks directly, already unlocked. There are several opportunities in the Gutenberg codebase to use this new feature. This PR does that:
ensureDefaultBlock, and accessingundoEditsandredoEdits.