Lodash: Refactor away from _.set() in global styles
#52279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
Mamaduka,
aristath,
brookewp,
chad1008,
fabiankaegy,
flootr,
jorgefilipecosta,
jsnajdr,
ntsekouras,
sgomes and
swissspidy
tyxla
force-pushed
the
remove/lodash-set-global-styles
branch
from
94b2cd9 to
6500e0f
Compare
tyxla
commented
Jul 4, 2023
Member
Author
There was a problem hiding this comment.
Pretty straightforward to trace - result is already declared to be an object, and setting is already a string, which is handled just fine by setImmutably once we split it to an array path.
Member
Author
There was a problem hiding this comment.
Simplifying because we don't need to deep clone - setImmutably will already do that.
Member
Author
There was a problem hiding this comment.
We just have to split contextualPath to an array path to have it properly handled by setImmutably.
Member
Author
There was a problem hiding this comment.
We just have to split finalPath to an array path to have it properly handled by setImmutably.
Member
Author
There was a problem hiding this comment.
Simplifying because we don't need to deep clone - setImmutably will already do that.
|
Size Change: -19 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
This was referenced Jul 4, 2023
tyxla
force-pushed
the
remove/lodash-set-global-styles
branch
from
53afeeb to
19bff9b
Compare
tyxla
force-pushed
the
remove/lodash-set-global-styles
branch
from
19bff9b to
2ffb692
Compare
Member
Author
|
Ready for a review after #52280 landed. |
|
Flaky tests detected in 2ffb692. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5483183123
|
This was referenced Jul 7, 2023
Mamaduka
approved these changes
Jul 7, 2023
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
The changes look good to me, and I couldn't spot any regressions when working with Global Styles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.set()from the global styles hooks.We have a few more usages of
set()left in the codebase, but we might have to tread carefully, since some of them may have to deal with Unicode characters, and I prefer testing them one by one.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're replacing the usage with the existing
setImmutablyutility function, which we're already utilizing in a few other places.Testing Instructions