Skip to content

Navigation: Fix e2e test failures caused by sidebar title change #52308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glendaviesnz merged 2 commits into from
Jul 5, 2023
Merged

Navigation: Fix e2e test failures caused by sidebar title change #52308

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6fb418
Revert "Navigation: Fix sidebar title (#52167)"
glendaviesnz Jul 5, 2023
7694b31
Check for object and string for title
glendaviesnz Jul 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Check for object and string for title
  • Loading branch information
@glendaviesnz
glendaviesnz committed Jul 5, 2023
commit 7694b310632d996b5b7369ef8bb35d885faa0e62
2 changes: 1 addition & 1 deletion ...it-site/src/components/sidebar-navigation-screen-pattern/template-part-navigation-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export default function TemplatePartNavigationMenu( { id } ) {
size="12"
upperCase={ true }
>
{ title?.rendered || __( 'Navigation' ) }
{ title?.rendered || title || __( 'Navigation' ) }
</Heading>
<NavigationMenuEditor navigationMenuId={ id } />
</>
Expand Down