Skip to content

Improve slug generation & matching in request utils #52414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 6 commits into from
Jul 20, 2023
Merged

Improve slug generation & matching in request utils #52414

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5438e4e
Lowercase plugin names before generating slugs
swissspidy Jul 7, 2023
63e22ec
Try to guess correct plugin slug
swissspidy Jul 7, 2023
da27a3b
Merge branch 'trunk' into fix/52411-kebab-case
swissspidy Jul 9, 2023
d5e3b03
Use `replace` instead of `replaceAll`
swissspidy Jul 9, 2023
0dc5ac5
Fix plugin slugs
swissspidy Jul 9, 2023
d6864a1
Merge branch 'trunk' into fix/52411-kebab-case
swissspidy Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Lowercase plugin names before generating slugs
  • Loading branch information
@swissspidy
swissspidy committed Jul 7, 2023
commit 5438e4e247b254f8644b076379a4014188e633b7
4 changes: 3 additions & 1 deletion packages/e2e-test-utils-playwright/src/request-utils/plugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ async function getPluginsMap( this: RequestUtils, forceRefetch = false ) {
for ( const plugin of plugins ) {
// Ideally, we should be using sanitize_title() in PHP rather than kebabCase(),
// but we don't have the exact port of it in JS.
this.pluginsMap[ kebabCase( plugin.name ) ] = plugin.plugin;
// This is a good approximation though.
const slug = kebabCase( plugin.name.toLowerCase() );
this.pluginsMap[ slug ] = plugin.plugin;
}
return this.pluginsMap;
}
Expand Down