Skip to content

Footnotes: save numbering through the entity provider #52423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcsf merged 9 commits into from
Jul 10, 2023
Merged

Footnotes: save numbering through the entity provider #52423

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
147760f
Footnotes: save numbering through the entity provider
ellatrix Jul 7, 2023
d86b6fb
Add sup so no styling is needed at all
ellatrix Jul 7, 2023
dad21a7
Migrate old format
ellatrix Jul 7, 2023
9b3f1b9
Restore old styles, fix nested attribute queries
ellatrix Jul 7, 2023
78d8c4a
Fix anchor selection
ellatrix Jul 7, 2023
6e544b1
Migrate markup in entity provider instead
ellatrix Jul 7, 2023
bbea094
Fix tests
ellatrix Jul 7, 2023
a0165e2
Fix typo
ellatrix Jul 7, 2023
7e78283
Fix comment
mcsf Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix comment
  • Loading branch information
@mcsf
mcsf committed Jul 10, 2023
commit 7e78283e47b61b77b59e0ec25b9fd9033b82fb8a
2 changes: 1 addition & 1 deletion packages/rich-text/src/component/use-select-object.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export function useSelectObject() {
if ( selection.containsNode( target ) ) return;

const range = ownerDocument.createRange();
// If the target in within a non editable element, select the non
// If the target is within a non editable element, select the non
// editable element.
const nodeToSelect = target.isContentEditable
? target
Expand Down