Skip to content

Item: Unify focus style and add default font styles #52495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 10 commits into from
Jul 13, 2023
Merged

Item: Unify focus style and add default font styles #52495

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
48a9691
ItemGroup: Apply focus state to `Item` component rendered as anchor e…
t-hamano Jul 11, 2023
ebe07be
Update changelog
t-hamano Jul 11, 2023
821a377
Don't apply text-decoration in the case of a button element
t-hamano Jul 11, 2023
1194265
Update snapshot
t-hamano Jul 11, 2023
5e88060
Merge branch 'trunk' into item/fix-focus-state-as-a
t-hamano Jul 12, 2023
48b6050
Update storybook and add default styles to anchor element
t-hamano Jul 12, 2023
672e399
Update snapshot
t-hamano Jul 12, 2023
74cdb6b
Update changelog
t-hamano Jul 12, 2023
9e29aab
Resolve conflicts
t-hamano Jul 13, 2023
51ef2f8
Fix incorrect changelog entries
t-hamano Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Resolve conflicts
  • Loading branch information
@t-hamano
t-hamano committed Jul 13, 2023
commit 9e29aab62415ba28743e617e7cbc09e4f293815a
2 changes: 1 addition & 1 deletion packages/block-library/src/block/block.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"title": "Pattern",
"category": "reusable",
"description": "Create and save content to reuse across your site. Update the pattern, and the changes apply everywhere it’s used.",
"keywords": [ "reusable" ],
"keywords": [ "reusable" ],
Copy link
Contributor Author

@t-hamano t-hamano Jul 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I merged the trunk, it included an unintended modification, but the indentation should be correct with this change 🙈

"textdomain": "default",
"attributes": {
"ref": {
Expand Down
4 changes: 2 additions & 2 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@

### Bug Fix

- `Popover`: Pin `react-dropdown-menu` version to avoid breaking changes in dependency updates. ([52356](https://github.com/WordPress/gutenberg/pull/52356)).
- `Item`: Unify focus style and add default font styles. ([52495](https://github.com/WordPress/gutenberg/pull/52495)).
- `Popover`: Pin `react-dropdown-menu` version to avoid breaking changes in dependency updates. ([52356](https://github.com/WordPress/gutenberg/pull/52356)).
- `Item`: Unify focus style and add default font styles. ([52495](https://github.com/WordPress/gutenberg/pull/52495)).
Copy link
Member

@mirka mirka Jul 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very important because it's just an optional check, but FYI the CI check for the changelog is failing because this is missing a number symbol:

Suggested change
- `Item`: Unify focus style and add default font styles. ([52495](https://github.com/WordPress/gutenberg/pull/52495)).
- `Item`: Unify focus style and add default font styles. ([#52495](https://github.com/WordPress/gutenberg/pull/52495)).


## 25.3.0 (2023-07-05)

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.