Skip to content

Enforce checks against redeclaration for functions and classes #52696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anton-vlasenko merged 30 commits into from
Jul 20, 2023
Merged

Enforce checks against redeclaration for functions and classes #52696

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
6cccfb4
Add Gutenberg coding standards package.
anton-vlasenko Jul 12, 2023
81b0852
Fix contributors.
anton-vlasenko Jul 12, 2023
6ebaf07
Fix package names.
anton-vlasenko Jul 12, 2023
887fab8
Remove unneccessary section.
anton-vlasenko Jul 12, 2023
d91104d
Add Gutenberg coding standards package as a composer dependency.
anton-vlasenko Jul 12, 2023
3e7fa24
Add myself as a code owner of the coding standards package.
anton-vlasenko Jul 12, 2023
37a7273
Exclude gutenberg coding standards from PHPCS checks.
anton-vlasenko Jul 17, 2023
4e12b71
Add the rule to phpcs.xml.dist.
anton-vlasenko Jul 17, 2023
e2f7e90
Guard functions and classes.
anton-vlasenko Jul 17, 2023
1cc8f77
Guard functions and classes.
anton-vlasenko Jul 17, 2023
7db4995
Fix CS.
anton-vlasenko Jul 17, 2023
835399b
Guard functions and classes.
anton-vlasenko Jul 17, 2023
0db5b14
Guard functions and classes.
anton-vlasenko Jul 17, 2023
a448571
Guard functions and classes.
anton-vlasenko Jul 17, 2023
4c44f1d
Guard functions and classes.
anton-vlasenko Jul 17, 2023
3b3e147
Guard functions and classes.
anton-vlasenko Jul 17, 2023
eee0473
Guard functions and classes.
anton-vlasenko Jul 17, 2023
f9c8746
Guard functions and classes.
anton-vlasenko Jul 17, 2023
4f50af3
Guard functions and classes.
anton-vlasenko Jul 17, 2023
4681443
Guard functions and classes.
anton-vlasenko Jul 17, 2023
73c6aae
Guard functions and classes.
anton-vlasenko Jul 17, 2023
a9d3806
Guard functions and classes.
anton-vlasenko Jul 17, 2023
f3da181
Guard functions and classes.
anton-vlasenko Jul 17, 2023
686d3e0
Guard functions and classes.
anton-vlasenko Jul 17, 2023
51e7ebe
Revert code style changes back.
anton-vlasenko Jul 17, 2023
ad92156
Fix cs errors.
anton-vlasenko Jul 18, 2023
42ec0e9
Move the package to `test/php`.
anton-vlasenko Jul 20, 2023
27dc135
Don't whitelist "WP.+Gutenberg" classes.
anton-vlasenko Jul 20, 2023
a088af5
Update code owners.
anton-vlasenko Jul 20, 2023
4457480
Fix indents.
anton-vlasenko Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix package names.
  • Loading branch information
@anton-vlasenko
anton-vlasenko committed Jul 20, 2023
commit 6ebaf07a920283b87380d20960959e39b706513a
6 changes: 3 additions & 3 deletions ...berg-coding-standards/Gutenberg/Sniffs/CodeAnalysis/GuardedFunctionAndClassNamesSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
/**
* Gutenberg Coding Standards.
*
* @package gutenberg-coding-standards/gbcs
* @link https://github.com/anton-vlasenko/Gutenberg-Coding-Standards
* @package gutenberg/gutenberg-coding-standards
* @link https://github.com/WordPress/gutenberg
* @license https://opensource.org/licenses/MIT MIT
*/

Expand All @@ -21,7 +21,7 @@
*
* @link https://github.com/WordPress/gutenberg/blob/trunk/lib/README.md#wrap-functions-and-classes-with--function_exists-and--class_exists
*
* @package gutenberg-coding-standards/gbcs
* @package gutenberg/gutenberg-coding-standards
*
* @since 1.0.0
*/
Expand Down
2 changes: 1 addition & 1 deletion ...rg-coding-standards/Gutenberg/Tests/CodeAnalysis/GuardedFunctionAndClassNamesUnitTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
* Unit test class for Gutenberg Coding Standard.
*
* @package gutenberg-coding-standards/gbc
* @link https://github.com/anton-vlasenko/Gutenberg-Coding-Standards
* @link https://github.com/WordPress/gutenberg
* @license https://opensource.org/licenses/MIT MIT
*/

Expand Down
6 changes: 3 additions & 3 deletions lib/experimental/packages/gutenberg/gutenberg-coding-standards/Tests/bootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
* - Load the Composer autoload file.
* - Automatically limit the testing to the WordPressCS tests.
*
* @package gutenberg-coding-standards/gbcs
* @link https://github.com/anton-vlasenko/Gutenberg-Coding-Standards
* @package gutenberg/gutenberg-coding-standards
* @link https://github.com/WordPress/gutenberg
* @license https://opensource.org/licenses/MIT MIT
*/

Expand Down Expand Up @@ -83,4 +83,4 @@
putenv( "PHPCS_IGNORE_TESTS={$standardsToIgnoreString}" );

// Clean up.
unset( $ds, $phpcsDir, $composerPHPCSPath, $allStandards, $standardsToIgnore, $standard, $standardsToIgnoreString );
unset( $ds, $phpcsDir, $composerPHPCSPath, $allStandards, $standardsToIgnore, $standard, $standardsToIgnoreString );