Skip to content

[Mobile] Update media placeholders and block outline #52702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geriux merged 20 commits into from
Jul 19, 2023
Merged

[Mobile] Update media placeholders and block outline #52702

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
da71015
Add new colors: $blue-60, $blue-40 and $dark-dim
Jul 17, 2023
14268bc
Gallery block - Remove native icon variant
Jul 17, 2023
00d8a72
Media Placeholder - Update colors
Jul 17, 2023
378235e
Embed - Update placeholder styles
Jul 17, 2023
6991c3b
Embed - Placeholder - Add button styles for the more options action
Jul 17, 2023
3caf096
Add back BlockOutline with update logic around parent blocks and medi…
Jul 17, 2023
2ce51c7
BlockOutline - Update paddings for text blocks
Jul 18, 2023
ff3866c
ButtonBlockAppender - Update left and right margins
Jul 18, 2023
cc1ed48
Update colors for media placeholders
Jul 18, 2023
87d0a40
Image component - Update selected styles
Jul 18, 2023
a7968f1
Merge branch 'trunk' into rnmobile/update-media-placeholders-and-bloc…
Jul 18, 2023
d095a4f
MediaPlaceholder - Fix missing touch action for the appender
Jul 18, 2023
4dfd049
Update styleMock
Jul 18, 2023
bcdaaf5
Audio and File block - Update component snapshot
Jul 18, 2023
989fff6
Update Embed, Gallery and Image tests to use new text placeholders
Jul 18, 2023
f298e58
Update block outline component to show border for unsupported blocks
Jul 19, 2023
eeeee97
Synced patterns - Fix seperator line to overflow outside the block's …
Jul 19, 2023
2209870
Unsupported block - Update placeholder styles
Jul 19, 2023
38b9a3f
E2E Test - Remove unsupported block test in favor of a visual test
Jul 19, 2023
ad16a7a
Missing block - Update snapshot
Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update colors for media placeholders
  • Loading branch information
Gerardo committed Jul 18, 2023
commit cc1ed48b7b4b8991abcc327f76942a03f8e74d0b
6 changes: 3 additions & 3 deletions packages/block-editor/src/components/media-placeholder/styles.native.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
flex-direction: column;
align-items: center;
justify-content: center;
background-color: #f5f5f5; // $light-ultra-dim
background-color: #e0e0e0; // $light-dim
padding-left: 12;
padding-right: 12;
padding-top: 12;
Expand Down Expand Up @@ -43,7 +43,7 @@
width: 24px;
height: 24px;
margin-right: $grid-unit;
fill: $light-tertiary;
fill: $light-secondary;
}

.media-placeholder__header-icon--dark {
Expand All @@ -53,7 +53,7 @@
.media-placeholder__header-title {
text-align: center;
font-size: 16;
color: $light-tertiary;
color: $light-secondary;
}

.media-placeholder__header-title--dark {
Expand Down
6 changes: 3 additions & 3 deletions packages/block-library/src/embed/styles.native.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
flex-direction: column;
align-items: center;
justify-content: center;
background-color: #f5f5f5; // $light-ultra-dim
background-color: #e0e0e0; // $light-dim
padding-left: 12;
padding-right: 12;
padding-top: 12;
Expand Down Expand Up @@ -41,7 +41,7 @@
}

.embed__icon {
fill: $light-tertiary;
fill: $light-secondary;
}

.embed__icon--dark {
Expand All @@ -57,7 +57,7 @@
}

.embed__label--dark {
color: $white;
color: $dark-tertiary;
}

.embed__description {
Expand Down