lint fixes

lib/experimental/fonts-library/class-wp-rest-fonts-library-controller.php

@@ -79,7 +79,7 @@ private function get_validation_errors( $font_families, $files ) {
 			return $error_messages;
 		}
 
-		// check if there is at least one font family
+		// Checks if there is at least one font family.
 		if ( count( $font_families ) < 1 ) {
 			$error_messages[] = __( 'fontFamilies should have at least one font family definition.', 'gutenberg' );
 			return $error_messages;
@@ -90,6 +90,7 @@ private function get_validation_errors( $font_families, $files ) {
 
 			if ( ! isset( $font_family['slug'] ) || ! isset( $font_family['name'] ) || ! isset( $font_family['fontFamily'] ) ) {
 				$error_messages[] = sprintf(
+					// translators: 1: font family index.
 					__( 'Font family [%s] should have slug, name and fontFamily properties defined.', 'gutenberg' ),
 					$family_index
 				);
@@ -98,13 +99,15 @@ private function get_validation_errors( $font_families, $files ) {
 			if ( isset( $font_family['fontFace'] ) ) {
 				if ( ! is_array( $font_family['fontFace'] ) ) {
 					$error_messages[] = sprintf(
+						// translators: 1: font family index.
 						__( 'Font family [%s] should have fontFace property defined as an array.', 'gutenberg' ),
 						$family_index
 					);
 				}
 
 				if ( count( $font_family['fontFace'] ) < 1 ) {
 					$error_messages[] = sprintf(
+						// translators: 1: font family index.
 						__( 'Font family [%s] should have at least one font face definition.', 'gutenberg' ),
 						$family_index
 					);
@@ -116,6 +119,7 @@ private function get_validation_errors( $font_families, $files ) {
 						$font_face = $font_family['fontFace'][ $face_index ];
 						if ( ! isset( $font_face['fontWeight'] ) || ! isset( $font_face['fontStyle'] ) ) {
 							$error_messages[] = sprintf(
+								// translators: 1: font family index, 2: font face index.
 								__( 'Font family [%1$s] Font face [%2$s] should have fontWeight and fontStyle properties defined.', 'gutenberg' ),
 								$family_index,
 								$face_index
@@ -124,6 +128,7 @@ private function get_validation_errors( $font_families, $files ) {
 
 						if ( isset( $font_face['download_from_url'] ) && isset( $font_face['uplodaded_file'] ) ) {
 							$error_messages[] = sprintf(
+								// translators: 1: font family index, 2: font face index.
 								__( 'Font family [%1$s] Font face [%2$s] should have only one of the download_from_url or uploaded_file properties defined and not both.', 'gutenberg' ),
 								$family_index,
 								$face_index
@@ -133,6 +138,7 @@ private function get_validation_errors( $font_families, $files ) {
 						if ( isset( $font_face['uploaded_file'] ) ) {
 							if ( ! isset( $files[ $font_face['uploaded_file'] ] ) ) {
 								$error_messages[] = sprintf(
+									// translators: 1: font family index, 2: font face index.
 									__( 'Font family [%1$s] Font face [%2$s] file is not defined in the request files.', 'gutenberg' ),
 									$family_index,
 									$face_index
@@ -155,7 +161,7 @@ private function get_validation_errors( $font_families, $files ) {
 	 *
 	 * @return true|WP_Error True if the parameter is valid, WP_Error otherwise.
 	 */
-	public function validate_install_font_families( $param, $request, $key ) {
+	public function validate_install_font_families( $param, $request ) {
 		$font_families  = json_decode( $param, true );
 		$files          = $request->get_file_params();
 		$error_messages = $this->get_validation_errors( $font_families, $files );

phpunit/fonts-library/class-wp-font-family-test.php

@@ -23,7 +23,7 @@ public function test_constructor_throws_exception_when_font_family_has_no_slug()
 		);
 		$this->expectException( 'Exception' );
 		$this->expectExceptionMessage( 'Font family data is missing the slug.' );
-		$font = new WP_Font_Family( $font_data );
+		new WP_Font_Family( $font_data );
 	}
 
 	/**

phpunit/fonts-library/class-wp-rest-fonts-library-controller-test.php

@@ -59,7 +59,7 @@ public function test_uninstall_non_existing_fonts() {
 
 		$uninstall_request->set_param( 'fontFamilies', $non_existing_font_data );
 		$response = rest_get_server()->dispatch( $uninstall_request );
-		$data     = $response->get_data();
+		$response->get_data();
 		$this->assertSame( 500, $response->get_status(), 'The response status is not 500.' );
 	}
 
@@ -70,9 +70,9 @@ public function test_uninstall_non_existing_fonts() {
 	 *
 	 * @dataProvider data_install_and_uninstall_fonts
 	 *
-	 * @param array $font_families     Font families to install in theme.json format
-	 * @param array $files             Font files to install
-	 * @param array $expected_response Expected response data
+	 * @param array $font_families     Font families to install in theme.json format.
+	 * @param array $files             Font files to install.
+	 * @param array $expected_response Expected response data.
 	 */
 	public function test_install_and_uninstall_fonts( $font_families, $files, $expected_response ) {
 		wp_set_current_user( self::$admin_id );
@@ -81,27 +81,27 @@ public function test_install_and_uninstall_fonts( $font_families, $files, $expec
 		$install_request->set_param( 'fontFamilies', $font_families_json );
 		$install_request->set_file_params( $files );
 		$response = rest_get_server()->dispatch( $install_request );
-		$data     = $response->get_data();
+		$response->get_data();
 
 		$this->assertSame( 200, $response->get_status(), 'The response status is not 200.' );
 		$this->assertCount( count( $expected_response ), $data, 'Not all the font families were installed correctly.' );
 
-		// Check that the font families were installed correctly
+		// Checks that the font families were installed correctly.
 		for ( $family_index = 0; $family_index < count( $data ); $family_index++ ) {
 			$installed_font = $data[ $family_index ];
 			$expected_font  = $expected_response[ $family_index ];
 
 			if ( isset( $installed_font['fontFace'] ) || isset( $expected_font['fontFace'] ) ) {
 				for ( $face_index = 0; $face_index < count( $installed_font['fontFace'] ); $face_index++ ) {
-					// Check that the font asset were created correctly
+					// Checks that the font asset were created correctly.
 					$this->assertStringEndsWith( $expected_font['fontFace'][ $face_index ]['src'], $installed_font['fontFace'][ $face_index ]['src'], 'The src of the fonts were not updated as expected.' );
-					// Remove the src from the response to compare the rest of the data
+					// Removes the src from the response to compare the rest of the data.
 					unset( $installed_font['fontFace'][ $face_index ]['src'] );
 					unset( $expected_font['fontFace'][ $face_index ]['src'] );
 				}
 			}
 
-			// Compare if the rest of the data is the same
+			// Compares if the rest of the data is the same.
 			$this->assertEquals( $expected_font, $installed_font, 'The endpoint answer is not as expected.' );
 		}