Skip to content

LineHeightControl: Allow for more granular control of decimal places #52902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikachan merged 25 commits into from
Aug 14, 2023
Merged

LineHeightControl: Allow for more granular control of decimal places #52902

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
e7de9f1
Change the line height step value from 0.1 to 0.01
mikachan Jul 24, 2023
7eef44b
Update test and related comments
mikachan Jul 25, 2023
7326a1c
Revert 0.1 to 0.01 step changes
mikachan Jul 26, 2023
de54c3a
Avoid using roundClamp for line height calculations
mikachan Jul 26, 2023
a596177
Introduce roundingStep prop to NumberControl
mikachan Jul 26, 2023
221bc6c
Update number-control tests to use string input values
mikachan Jul 27, 2023
b0dcb54
Add changelog entry
mikachan Jul 27, 2023
1984787
Merge branch 'trunk' into update/line-height-step
mikachan Jul 27, 2023
635541d
Try spincrement prop
mikachan Aug 1, 2023
dc07a63
Handle rounding logic with two decimals
mikachan Aug 4, 2023
96db4f3
Merge branch 'trunk' into update/line-height-step
mikachan Aug 4, 2023
00645ef
Fix rounding up logic
mikachan Aug 4, 2023
d9171a5
Merge branch 'trunk' into update/line-height-step
mikachan Aug 7, 2023
82d2061
Tweak type comments and changelog entry
mikachan Aug 7, 2023
e49d57e
Merge branch 'trunk' into update/line-height-step
mikachan Aug 7, 2023
c6597a4
Revert specialised rounding in LineHeightControl
mikachan Aug 8, 2023
f50fd71
Fix spin rounding in NumberControl
mikachan Aug 8, 2023
5d1ff88
Replace spincrement with spinFactor
mikachan Aug 8, 2023
dce0c45
Update line height control unit tests
stokesman Aug 8, 2023
9d55569
Merge branch 'trunk' into update/line-height-step
mikachan Aug 9, 2023
d25ca2b
Update packages/components/src/number-control/index.tsx
mikachan Aug 11, 2023
6d35ba7
Update packages/components/src/number-control/index.tsx
mikachan Aug 11, 2023
4c7d545
Add tests that include use of spinFactor prop
mikachan Aug 11, 2023
facc66f
Add tests for shiftStep + spinFactor
mikachan Aug 11, 2023
8004d1a
Merge branch 'trunk' into update/line-height-step
mikachan Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'trunk' into update/line-height-step
  • Loading branch information
@mikachan
mikachan authored Aug 7, 2023
commit e49d57efd62f93a467b5c9693678fca9b6ecaa25
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
- `TabPanel`: Introduce a new version of `TabPanel` with updated internals and improved adherence to ARIA guidance on `tabpanel` focus behavior while maintaining the same functionality and API surface.([#52133](https://github.com/WordPress/gutenberg/pull/52133)).
- `Theme`: Expose via private APIs ([#53262](https://github.com/WordPress/gutenberg/pull/53262)).
- `ProgressBar`: Use the theme system accent for indicator color ([#53347](https://github.com/WordPress/gutenberg/pull/53347)).
- `ProgressBar`: Use gray 300 for track color ([#53349](https://github.com/WordPress/gutenberg/pull/53349)).
- `NumberControl`: Add `spincrement` prop to allow for alternative rounding behavior when using the spin controls ([#52902](https://github.com/WordPress/gutenberg/pull/52902)).

### Bug Fix
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.