Interactivity API: remove the wp-show directive temporarily#53240
Merged
luisherranz merged 6 commits intotrunkfrom Aug 2, 2023
Merged
Interactivity API: remove the wp-show directive temporarily#53240luisherranz merged 6 commits intotrunkfrom
wp-show directive temporarily#53240luisherranz merged 6 commits intotrunkfrom
Conversation
luisherranz
added
the
[Feature] Interactivity API
luisherranz
added
[Type] Breaking Change
|
Size Change: +227 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 58f4424. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5736594261
|
luisherranz
requested review from
Mamaduka,
ajitbohra,
kevin940726,
nerrad and
ntwb
as code owners
luisherranz
changed the title
wp-show directivewp-show directive temporarily
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove the
wp-showdirective temporarily.Why?
Because the final implementation is not clear yet, and it doesn't have server-side rendering support yet.
How?
Just remove the directive from the runtime, remove its e2e tests, and create a
wp-show-mockdirective for the e2e tests that were using it to test when things are removed from the DOM.