Skip to content

Components: Expose Theme via private APIs #53262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tyxla merged 5 commits into from
Aug 4, 2023
Merged

Components: Expose Theme via private APIs #53262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee0fdb9
Components: Expose Theme as a private API
tyxla Aug 2, 2023
316afe9
Remove invalid experimental example from README
tyxla Aug 2, 2023
e42d0ef
Fix inline example to use private API
tyxla Aug 2, 2023
c2dbd87
Add CHANGELOG entry
tyxla Aug 2, 2023
87e9815
Remove private API access from Theme inline example
tyxla Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- `ColorPalette`, `BorderControl`: Don't hyphenate hex value in `aria-label` ([#52932](https://github.com/WordPress/gutenberg/pull/52932)).
- `MenuItemsChoice`, `MenuItem`: Support a `disabled` prop on a menu item ([#52737](https://github.com/WordPress/gutenberg/pull/52737)).
- `TabPanel`: Introduce a new version of `TabPanel` with updated internals and improved adherence to ARIA guidance on `tabpanel` focus behavior while maintaining the same functionality and API surface.([#52133](https://github.com/WordPress/gutenberg/pull/52133)).
- `Theme`: Expose via private APIs ([#53262](https://github.com/WordPress/gutenberg/pull/53262)).

### Bug Fix

Expand Down
2 changes: 2 additions & 0 deletions packages/components/src/private-apis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
DropdownSubMenuTrigger as DropdownSubMenuTriggerV2,
} from './dropdown-menu-v2';
import { ComponentsContext } from './ui/context/context-system-provider';
import Theme from './theme';

export const { lock, unlock } =
__dangerousOptInToUnstableAPIsOnlyForCoreModules(
Expand All @@ -47,4 +48,5 @@ lock( privateApis, {
DropdownSubMenuV2,
DropdownSubMenuTriggerV2,
ProgressBar,
Theme,
} );
17 changes: 0 additions & 17 deletions packages/components/src/theme/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,6 @@ This feature is still experimental. “Experimental” means this is an early im

Multiple `Theme` components can be nested in order to override specific theme variables.

## Usage

```jsx
import { __experimentalTheme as Theme } from '@wordpress/components';

const Example = () => {
return (
<Theme accent="red">
<Button variant="primary">I'm red</Button>
<Theme accent="blue" background="black">
<Button variant="primary">I'm blue</Button>
</Theme>
</Theme>
);
};
```

## Props

### `accent`: `string`
Expand Down
2 changes: 0 additions & 2 deletions packages/components/src/theme/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ import { useCx } from '../utils';
*
* @example
* ```jsx
* import { __experimentalTheme as Theme } from '@wordpress/components';
*
* const Example = () => {
* return (
* <Theme accent="red">
Expand Down