Interactivity API: Add support for underscores and leading dashes in the suffix part of the directive#53337
Merged
cbravobernal merged 2 commits intotrunkfrom Aug 4, 2023
Merged
Conversation
cbravobernal
added
[Type] Bug
cbravobernal
requested review from
DAreRodz,
Mamaduka,
ajitbohra,
kevin940726,
luisherranz,
nerrad and
ntwb
as code owners
luisherranz
approved these changes
Aug 4, 2023
Member
luisherranz
left a comment
luisherranz
left a comment
There was a problem hiding this comment.
Codewise looks good to me.
Can you please add an entry to the changelog?
Also, is the removal of the final $ intended?
luisherranz
changed the title
|
Size Change: -1 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Allow data-wp-class to contain classes with underscores, like BEM notation.
Why?
Cause WordPress is using this notation for their classes, and, trying to migrate Search block to the Interactivity API, I found that the directive was not processed for the class that hides the search input.
How?
Changing REGEX 😭
Testing Instructions
I added a couple of tests, but still, feel free to test it by using
data-wp-class--underscores__for_the_winin an interactive block and check that everything is working as expected.Testing Instructions for Keyboard
Screenshots or screencast