Allow passing optional afterLoad callbacks to store calls#53363
Merged
Allow passing optional afterLoad callbacks to store calls#53363
afterLoad callbacks to store calls#53363Conversation
13 tasks
luisherranz
added
[Type] Feature
DAreRodz
force-pushed
the
add/interactivity-api-afterload-callback
branch
from
32c396e to
9ca6552
Compare
DAreRodz
requested review from
Mamaduka,
ajitbohra,
kevin940726,
luisherranz,
nerrad and
ntwb
as code owners
Contributor
Author
|
@luisherranz ready for review ☝️ |
|
Size Change: +32 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
artemiomorales
approved these changes
Aug 7, 2023
Contributor
artemiomorales
left a comment
artemiomorales
left a comment
There was a problem hiding this comment.
Looks good to me!
Contributor
Author
|
Thanks, @artemiomorales. I'll wait for @luisherranz to take a look as well before merging. 😊 |
luisherranz
requested changes
Aug 9, 2023
Member
luisherranz
left a comment
luisherranz
left a comment
There was a problem hiding this comment.
Codewise everything looks good. Great tests by the way 🙂
Would you mind adding a new section to the API reference to document the options argument and in there, the afterLoad option? It doesn't have to be extensive, we can improve it later, but at least we should mention it. Thanks!!
|
Flaky tests detected in 58447c8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5822624113
|
8 tasks
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Allow developers to pass callbacks to the Interactivity API
storefunction, e.g.,Why?
Some block types would need to initialize stuff in the global state, which might require the store to be ready.
How?
A
Setinstance stores all the passedafterLoadcallbacks to avoid duplicates. All registered callbacks run right after theinit()function, receiving the global store.Testing Instructions
It includes e2e tests that should pass.