Skip to content

Mobile - RCTAztecView - Fixes font customization not getting updated #53391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geriux merged 6 commits into from
Aug 16, 2023
Merged

Mobile - RCTAztecView - Fixes font customization not getting updated #53391

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
079e4bf
Mobile - RCTAztecView - Fixes font customization not getting updated …
Aug 7, 2023
a7658ac
Update typingAttributes with the updated font
Aug 8, 2023
299f59f
Merge branch 'trunk' into rnmobile/fix/ios-font-customization
Aug 8, 2023
d4f17d0
Update Changelog
Aug 8, 2023
6158b23
Remove unneeded changes
Aug 8, 2023
04bbafb
Merge branch 'trunk' into rnmobile/fix/ios-font-customization
Aug 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unneeded changes
  • Loading branch information
Gerardo committed Aug 8, 2023
commit 6158b234c3380df9f6aa5db078cb32d359a5f98d
11 changes: 1 addition & 10 deletions packages/react-native-aztec/ios/RNTAztecView/RCTAztecView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ class RCTAztecView: Aztec.TextView {
let label = UILabel(frame: .zero)
label.translatesAutoresizingMaskIntoConstraints = false
label.textAlignment = .natural
label.font = font

return label
}()
Expand Down Expand Up @@ -574,19 +575,9 @@ class RCTAztecView: Aztec.TextView {
var placeholderAttributes: [NSAttributedString.Key: Any] {
var placeholderAttributes = typingAttributes
placeholderAttributes[.foregroundColor] = placeholderTextColor
placeholderAttributes[.font] = placeholderFont
return placeholderAttributes
}

@objc var placeholderFont: UIFont {
set {
placeholderLabel.font = newValue
}
get {
return placeholderLabel.font
}
}

@objc var placeholderTextColor: UIColor {
set {
placeholderLabel.textColor = newValue
Expand Down