Skip to content

Fix crash by moving editor style logic into a hook with useMemo #53596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 4 commits into from
Aug 15, 2023
Merged

Fix crash by moving editor style logic into a hook with useMemo #53596

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31bb1f4
Move editor style logic into a hook whith useMemo
noahtallen Aug 11, 2023
6f32b8f
Remove unnecessary useMemo
noahtallen Aug 12, 2023
d7d917b
Move the whole logic inside the 'useMemo'
Mamaduka Aug 15, 2023
00c5a78
Add missing useSelect dep
Mamaduka Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add missing useSelect dep
  • Loading branch information
@Mamaduka
Mamaduka committed Aug 15, 2023
commit 00c5a78f60982c365d7eccc61fcda7cb1b99a42c
3 changes: 2 additions & 1 deletion packages/edit-post/src/components/layout/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ function useEditorStyles() {
hasThemeStyleSupport:
select( editPostStore ).isFeatureActive( 'themeStyles' ),
editorSettings: select( editorStore ).getEditorSettings(),
} )
} ),
[]
);

// Compute the default styles.
Expand Down