Skip to content

Fix typo and add tests for fonts install endpoint #53644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matiasbenedetto merged 9 commits into from
Aug 14, 2023
Merged

Fix typo and add tests for fonts install endpoint #53644

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7e34261
Fix typo
matiasbenedetto Aug 11, 2023
00f8846
fixing get validations error logic
matiasbenedetto Aug 14, 2023
7bfeb77
adding tests to specify when the endpoit should respond with 400 (bad…
matiasbenedetto Aug 14, 2023
d0e6058
deleting unused variable
matiasbenedetto Aug 14, 2023
26157f9
validate if all the referenced files exists in the request
matiasbenedetto Aug 14, 2023
a775572
adding comments and format
matiasbenedetto Aug 14, 2023
5ca7a92
Formatting and Core parity improvements.
hellofromtonya Aug 14, 2023
451ec8d
Fix phpcs alignment in tests
hellofromtonya Aug 14, 2023
fc5c007
Fix spacing whoopsie in tests
hellofromtonya Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix phpcs alignment in tests
  • Loading branch information
@hellofromtonya
hellofromtonya authored Aug 14, 2023
commit 451ec8d8f00e9bff34819213aa2d44fb353fec64
11 changes: 7 additions & 4 deletions phpunit/fonts-library/class-wp-rest-fonts-library-controller-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,15 +369,18 @@ public function data_install_with_improper_inputs() {
file_put_contents( $temp_file_path1, 'Mocking file content' );

return array(
'not a font families array' => array(
'not a font families array'
=> array(
'font_families' => 'This is not an array',
),

'empty array' => array(
'empty array'
=> array(
'font_families' => array(),
),

'without slug' => array(
'without slug'
=> array(
'font_families' => array(
array(
'fontFamily' => 'Piazzolla',
Expand All @@ -397,7 +400,7 @@ public function data_install_with_improper_inputs() {
),
),

'with empty font face propety' => array(
'with empty font face property' => array(
'font_families' => array(
array(
'fontFamily' => 'Piazzolla',
Expand Down