Skip to content

Try: Block API: Remove children source in favor of HTML string #5380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aduth wants to merge 2 commits into from
Closed

Try: Block API: Remove children source in favor of HTML string #5380

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2ad6f8
Parser: Enable filterable attribute source
aduth Feb 24, 2018
0938b93
Block API: Remove children source in favor of HTML string
aduth Mar 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Parser: Enable filterable attribute source
  • Loading branch information
@aduth
aduth committed Mar 3, 2018
commit c2ad6f81563e9b38c7aeb8b0f3e97db078d6dd8d
11 changes: 10 additions & 1 deletion blocks/api/parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { mapValues, omit } from 'lodash';
* WordPress dependencies
*/
import { autop } from '@wordpress/autop';
import { applyFilters } from '@wordpress/hooks';

/**
* Internal dependencies
Expand Down Expand Up @@ -118,7 +119,15 @@ export function getBlockAttribute( attributeKey, attributeSchema, innerHTML, com
break;
}

return value === undefined ? attributeSchema.default : asType( value, attributeSchema.type );
value = applyFilters( 'blocks.getBlockAttribute.source', value, attributeSchema, innerHTML, commentAttributes );

if ( value === undefined ) {
value = attributeSchema.default;
} else {
value = asType( value, attributeSchema.type );
}

return applyFilters( 'blocks.getBlockAttribute', value, attributeSchema, innerHTML, commentAttributes );
}

/**
Expand Down