Skip to content

Fix: indicator style when block moving mode #53972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 1 commit into from
Aug 29, 2023
Merged

Fix: indicator style when block moving mode #53972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/block-editor/src/components/block-list/content.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@
.block-editor-block-list__block.is-highlighted,
.block-editor-block-list__block.is-highlighted ~ .is-multi-selected,
&.is-navigate-mode .block-editor-block-list__block.is-selected,
& .is-block-moving-mode.block-editor-block-list__block.has-child-selected,
Copy link
Contributor Author

@t-hamano t-hamano Aug 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .is-block-moving-mode class is given only to the selected block. Therefore, there can never be a block that has both the .is-block-moving-mode class and the .has-child-selected class.

.block-editor-block-list__block:not([contenteditable]):focus {
outline: none;

Expand Down Expand Up @@ -113,8 +112,6 @@

// Moving blocks using keyboard (Ellipsis > Move).
& .is-block-moving-mode.block-editor-block-list__block.is-selected {
box-shadow: none;
outline: none;
Comment on lines -116 to -117
Copy link
Contributor Author

@t-hamano t-hamano Aug 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The absence of this reset style does not affect the indicator.


&::after {
content: "";
Expand All @@ -130,6 +127,8 @@
top: -$default-block-margin * 0.5;
border-radius: $radius-block-ui;
border-top: 4px solid $gray-400;
bottom: auto;
box-shadow: none;
}
}

Expand Down