[Commands]: Fix block editor commands availability #53994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
Mamaduka,
richtabor,
t-hamano and
youknowriad
|
Size Change: +6 B (0%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3eca390. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6001793419
|
17 tasks
draganescu
approved these changes
Aug 29, 2023
Contributor
draganescu
left a comment
draganescu
left a comment
There was a problem hiding this comment.
Tested and works great, thank you @ntsekouras 🙏🏻
t-hamano
reviewed
Aug 29, 2023
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR! It appears to be mostly fine, but I would like to comment on a few points of concern.
t-hamano
reviewed
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #53921
This PR handles:
allowed_block_types_all hook.canRemoveBlocksis false.Testing Instructions