-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Font Library: load collection JSON data from a URL in the collection config #54067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
79d6af7
Adding Font Collection class
matiasbenedetto fd1c967
php formatting and linting
matiasbenedetto 0cfac6c
Adding tests for collections routes
matiasbenedetto 6bb2f8b
Adding tests for WP_Font_Collection constructor
matiasbenedetto 4a67d0b
adding tests for WP_Font_Collection get_data()
matiasbenedetto b26cb63
adding tests for WP_Font_Library register_font_collection()
matiasbenedetto 0cfddb2
get font collection tests
matiasbenedetto 7ba6f61
adding 'wp_' prefix to the 'register_font_collection' filter name
matiasbenedetto 454f9a5
fix callback name
matiasbenedetto 932064f
making class property private
matiasbenedetto b184398
registering filter from font-library.php file
matiasbenedetto 6a2dfa0
Merge branch 'trunk' into try/font-collections
matiasbenedetto 36ab188
removing superfluous comment
matiasbenedetto ac938c9
moving files to according changes in trunk
matiasbenedetto a9c7b6a
config without a json file should fail
matiasbenedetto b2deb14
fix property name in tests
matiasbenedetto 4765538
name fix
matiasbenedetto 3fb8b0a
comment update
matiasbenedetto 3fadd9d
Adds WP_Error to return type
hellofromtonya bdaacf8
Improves contructor error handling.
hellofromtonya 85fe753
FontCollection::get_data(): Improves error handling
hellofromtonya 4ae9af6
Removes empty space for wpcs
hellofromtonya de053da
adding filter in a simpler way
matiasbenedetto 21dfbe3
micro-optimization
matiasbenedetto fb913af
reuse WP_Error response instead of creating a new one
matiasbenedetto 0e6c026
Eliminates try/catch
hellofromtonya f79212d
Revert "Eliminates try/catch" commit
hellofromtonya 4e952e3
Remove wp_register_font_collection and replace it by a global functio…
matiasbenedetto 196459a
adding function comment and guard agains re-declaration
matiasbenedetto a76d943
php format
matiasbenedetto c15b5ae
fixing docblock coments
matiasbenedetto 85261b3
removing param comment
matiasbenedetto ad52829
re-adding parameter comment removed by mistake
matiasbenedetto 7161ba1
format php
matiasbenedetto 8402b91
updating WP_Font_Collection __construct tests
matiasbenedetto e0947c9
updating WP_Font_Collection get_data tests
matiasbenedetto 98d52ad
updating tests
matiasbenedetto a6ed145
php format
matiasbenedetto f8dc1a0
array check
matiasbenedetto 4cb5c77
Documents config array structure
hellofromtonya 4b7e5e3
adding tests for /fonts/collections endpoint
matiasbenedetto 56607c9
adding /fonts/collections/<id> endpoint test
matiasbenedetto c928ebe
format
matiasbenedetto aeb42cf
format
matiasbenedetto 0a98de6
add test for missing collection
matiasbenedetto 46f9fde
removing not needed variables
matiasbenedetto 785262b
Add more tests and split the test for WP_REST_Font_Library_Controller
matiasbenedetto de12fe7
lint
matiasbenedetto dc560b8
try to create dir for tests in CI
matiasbenedetto 60997e9
Merge branch 'trunk' into try/font-collections
matiasbenedetto f87f538
renane config property to src and handle URLs apart from file paths
matiasbenedetto f55f7a7
Add the ability to load collection JSON data from a URL
matiasbenedetto 0df9a0e
remove unwanted comment
matiasbenedetto 7cc1dd3
merge with trunk
matiasbenedetto 31a6315
fix missing merge
matiasbenedetto 7d8e6e3
fix merge with trunk
matiasbenedetto 4eadf1a
removing test file after merge with trunk
matiasbenedetto 08f2e48
removing duplicated test files after merge with trunk
matiasbenedetto ebb5b7b
Merge branch 'trunk' into try/font-collections-url
matiasbenedetto 61568e0
decode data to make availanle in the client as json
matiasbenedetto 678aaef
update google fonts collection source
matiasbenedetto a097eca
format php'
matiasbenedetto 0022826
removing the default font collection (google fonts) json file from repo
matiasbenedetto bdd756f
fixing logic to get data from url
matiasbenedetto d51a3ff
add tests to try the font collection fetching from url
matiasbenedetto 44acc0c
update test
matiasbenedetto 08fc24b
format comments
matiasbenedetto a047eb7
replacing existing url in test with a mock url
matiasbenedetto 241f2a6
early return
matiasbenedetto baa8114
remove not needed filter
matiasbenedetto e4d7565
rewording error message
matiasbenedetto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
decode data to make availanle in the client as json
- Loading branch information
commit 61568e046685683b8fdd7ba1fcf3551bd88c9dcc
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.