Skip to content

HTML block: Fix accessibility issues on back-end #54408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexstine merged 12 commits into from
Sep 20, 2023
Merged

HTML block: Fix accessibility issues on back-end #54408

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
baafaaa
Accessibility fixes for HTML block.
alexstine Sep 13, 2023
7f70f29
Remove focus handling code.
alexstine Sep 13, 2023
75fb6b7
Cleaner useInstanceId handling.
alexstine Sep 13, 2023
2163d54
Add tabindex -1 and title to iFrame.
alexstine Sep 13, 2023
8f9c5d5
README and changelog.
alexstine Sep 13, 2023
0964e6f
Fix conflict.
alexstine Sep 13, 2023
1bb8ea7
Reviewer feedback and refresh.
alexstine Sep 18, 2023
8207748
Revert odd changes.
alexstine Sep 18, 2023
6511280
Reviewer feedback.
alexstine Sep 19, 2023
99c0f45
Refresh.
alexstine Sep 19, 2023
fde547b
Merge branch 'trunk' of github.com:WordPress/gutenberg into fix/html-…
alexstine Sep 19, 2023
54172bc
Revert change.
alexstine Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refresh.
  • Loading branch information
@alexstine
alexstine committed Sep 19, 2023
commit 99c0f45df98871860f50ae7c5984da4b21fd52d4
2 changes: 2 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
- `FormTokenField`: Update styling for consistency and increased visibility ([#54402](https://github.com/WordPress/gutenberg/pull/54402)).
- `CircularOptionPicker`: Add option to use previous non-listbox behaviour, for contexts where buttons are more appropriate than a list of options ([#54290](https://github.com/WordPress/gutenberg/pull/54290)).
- `DuotonePicker/ColorListPicker`: Adds appropriate labels to 'Duotone Filter' color pickers ([#54468](https://github.com/WordPress/gutenberg/pull/54468)).
- `SearchControl`: support new `40px` and `32px` sizes ([#54548](https://github.com/WordPress/gutenberg/pull/54548)).
- `FormTokenField`: Add `tokenizeOnBlur` prop to add any incompleteTokenValue as a new token when field loses focus ([#54445](https://github.com/WordPress/gutenberg/pull/54445)).
- `Sandbox`: Add `tabIndex` prop ([#54408](https://github.com/WordPress/gutenberg/pull/54408)).

### Bug Fix
Expand Down
17 changes: 7 additions & 10 deletions packages/edit-site/lib/unbrotli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,12 +332,11 @@
0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0,
1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1,
0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0, 1, 0,
1, 0, 1, 0, 1, 0, 1, /* UTF8 lead byte range. */
1, 0, 1, 0, 1, 0, 1 /* UTF8 lead byte range. */, 2, 3,
2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2,
3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3,
2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2, 3, 2,
3, 2, 3, 2, 3, 2, 3,
/* CONTEXT_UTF8 second last byte. */
3, 2, 3, 2, 3 /* CONTEXT_UTF8 second last byte. */,
/* ASCII range. */
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, 1,
Expand All @@ -351,11 +350,10 @@
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, /* UTF8 lead byte range. */
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 2, 2,
0, 0, 0, 0 /* UTF8 lead byte range. */, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 2, 2, 2, 2, 2, 2, 2, 2,
2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,
2, 2, 2, 2, 2, 2, 2, 2, 2, 2,
/* CONTEXT_SIGNED, second last byte. */
2, 2, 2, 2, 2 /* CONTEXT_SIGNED, second last byte. */,
0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 2, 2, 2,
2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,
2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,
Expand Down Expand Up @@ -447,9 +445,8 @@

exports.lookupOffsets = new Uint16Array( [
/* CONTEXT_LSB6 */
1024, 1536, /* CONTEXT_MSB6 */
1280, 1536, /* CONTEXT_UTF8 */
0, 256, /* CONTEXT_SIGNED */
1024, 1536 /* CONTEXT_MSB6 */, 1280,
1536 /* CONTEXT_UTF8 */, 0, 256 /* CONTEXT_SIGNED */,
768, 512,
] );
},
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.