Skip to content

Remove base url from link control search results #54553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getdave merged 14 commits into from
Sep 21, 2023
Merged

Remove base url from link control search results #54553

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
158c841
Expose baseURL setting on Post and Site Editors via block settings
getdave Sep 18, 2023
37e9bb1
Strip baseURL from rendered search results
getdave Sep 18, 2023
25c576a
Only fetch baseURL once in top level component
getdave Sep 18, 2023
bb545d8
Simplify implementation to utilise URL parse functions
getdave Sep 18, 2023
1e95736
Improve comment wording to avoid referencing undefined var
getdave Sep 18, 2023
9b84981
Remove superfluous conditional
getdave Sep 19, 2023
0d12f6f
Decode URL prior to operations
getdave Sep 19, 2023
5808ca7
Refactor for readability
getdave Sep 19, 2023
956152a
Fix where url is not defined
getdave Sep 19, 2023
dd9e6c4
Revert change to filter util
getdave Sep 19, 2023
724bffc
Ensure that filterURLForDisplay always receives a string as an arg
getdave Sep 19, 2023
d2e54f9
Make e2e test locator less strict
getdave Sep 19, 2023
67a4b67
Prefer pipe
getdave Sep 19, 2023
868b3e4
Force remove trailing slash
getdave Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make e2e test locator less strict
  • Loading branch information
@getdave
getdave committed Sep 19, 2023
commit d2e54f94f0710d0ff1b8a233f0417d7e5dca1be3
8 changes: 3 additions & 5 deletions test/e2e/specs/editor/blocks/navigation-list-view.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ test.describe( 'Navigation block - List view editing', () => {
hasText: 'Block 2 of 2, Level 1', // proxy for filtering by description.
} )
.getByText( 'Top Level Item 2' )
).not.toBeVisible();
).toBeHidden();
} );

test( `can edit menu items`, async ( { page, editor, requestUtils } ) => {
Expand Down Expand Up @@ -525,7 +525,7 @@ test.describe( 'Navigation block - List view editing', () => {
// Check that despite being the last inserted block, the Link UI is not displayed
// in this scenario because it was not **just** inserted into the List View (i.e.
// we have unmounted the list view and then remounted it).
await expect( linkControl.getSearchInput() ).not.toBeVisible();
await expect( linkControl.getSearchInput() ).toBeHidden();
} );
} );

Expand Down Expand Up @@ -573,9 +573,7 @@ class LinkControl {
await expect( result ).toBeVisible();

return result
.locator(
'.components-menu-item__info-wrapper .components-menu-item__item'
) // this is the only way to get the label text without the URL.
.locator( '.components-menu-item__item' ) // this is the only way to get the label text without the URL.
.innerText();
}
}