Conversation
stokesman
added
[Type] Automated Testing
|
Size Change: +368 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7e8f3d1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6226004862
|
ciampo
approved these changes
Sep 19, 2023
Contributor
ciampo
left a comment
ciampo
left a comment
There was a problem hiding this comment.
Thank you @stokesman ! Code looks great 🚀
Let's add a CHANGELOG entry and merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
user-eventlibrary.Why?
While working on #51602, these behaviors were initially overlooked because they a bit obscure. Without tests these behaviors might be inadvertently broken later on.
How?
Asserts expected behaviors in three new tests.
Testing Instructions
.skipfrom test at line 170 ofpackages/components/src/modal/test/index.tsx.