Skip to content

Font Library: move font uploads to a new tab #54655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matiasbenedetto merged 5 commits into from
Sep 28, 2023
Merged

Font Library: move font uploads to a new tab #54655

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
97dcd1f
move font uploads to a new tab in the modal
madhusudhand Sep 20, 2023
a30cfe8
fix invalid success message and revert the dropzone to modal
madhusudhand Sep 25, 2023
a4c5dd3
add success notice for font uploads
madhusudhand Sep 25, 2023
81e7c64
make supported file formats message dynamic based on allowed extensions
madhusudhand Sep 25, 2023
d94b1f4
update hint text and clear successful message with a fresh upload
madhusudhand Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add success notice for font uploads
  • Loading branch information
@madhusudhand
madhusudhand committed Sep 27, 2023
commit a4c5dd3acaf7e3f476f23049f1bbd19368cca62f
11 changes: 9 additions & 2 deletions packages/edit-site/src/components/global-styles/font-library-modal/local-fonts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { loadFontFaceInBrowser } from './utils';

function LocalFonts() {
const { installFonts } = useContext( FontLibraryContext );
const [ notice ] = useState( null );
const [ notice, setNotice ] = useState( null );

const handleDropZone = ( files ) => {
handleFilesUpload( files );
Expand Down Expand Up @@ -130,7 +130,14 @@ function LocalFonts() {
*/
const handleInstall = async ( fontFaces ) => {
const fontFamilies = makeFamiliesFromFaces( fontFaces );
await installFonts( fontFamilies );
setNotice( null );
const status = await installFonts( fontFamilies );
if ( status ) {
setNotice( {
type: 'success',
message: __( 'Upload successful.' ),
} );
}
};

return (
Expand Down