Skip to content

Font Library: refactor endpoint permissions #54829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matiasbenedetto merged 8 commits into from
Sep 29, 2023
Merged

Font Library: refactor endpoint permissions #54829

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
522a1a9
break the checking of user permission and file write permissions
matiasbenedetto Sep 26, 2023
4248733
Merge branch 'trunk' into refactor/font-library-endpoint-permissions
matiasbenedetto Sep 28, 2023
fad89f5
return error 500 if the request to the install fonts endpoint needs w…
matiasbenedetto Sep 28, 2023
a153cae
do not ask file write permission on uninstall endpoint
matiasbenedetto Sep 28, 2023
9f726d4
Standardize the output of install and uninstall fonts endpoints
matiasbenedetto Sep 29, 2023
19ca6bc
Handle standardized output from install and uninstall endpoints in th…
matiasbenedetto Sep 29, 2023
be038aa
Update the install and unintall fonts endpoints unit tests for the ne…
matiasbenedetto Sep 29, 2023
170ebd9
fix the refersh call for the library
matiasbenedetto Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
do not ask file write permission on uninstall endpoint
  • Loading branch information
@matiasbenedetto
matiasbenedetto committed Sep 28, 2023
commit a153caed899c6779934d2e7867ec8f97f8d2b4a0
16 changes: 4 additions & 12 deletions lib/experimental/fonts/font-library/class-wp-rest-font-library-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,25 +289,17 @@ public function uninstall_schema() {
* @return WP_REST_Response|WP_Error Response object on success, or WP_Error object on failure.
*/
public function uninstall_fonts( $request ) {
$fonts_param = $request->get_param( 'fontFamilies' );
$fonts_to_uninstall = $request->get_param( 'fontFamilies' );

if ( empty( $fonts_to_install ) ) {
if ( empty( $fonts_to_uninstall ) ) {
return new WP_Error(
'no_fonts_to_install',
__( 'No fonts to uninstall', 'gutenberg' ),
array( 'status' => 400 )
);
}

$needs_write_permission = $this->needs_write_permission( $fonts_to_install );
if ( $needs_write_permission ) {
$write_permission = $this->has_write_permission();
if ( is_wp_error( $write_permission ) ) {
return $write_permission;
}
}

foreach ( $fonts_param as $font_data ) {
foreach ( $fonts_to_uninstall as $font_data ) {
$font = new WP_Font_Family( $font_data );
$result = $font->uninstall();

Expand All @@ -317,7 +309,7 @@ public function uninstall_fonts( $request ) {
}
}

return new WP_REST_Response( __( 'Font family uninstalled successfully.', 'gutenberg' ), 200 );
return new WP_REST_Response( __( 'Font families uninstalled successfully.', 'gutenberg' ), 200 );
}

/**
Expand Down