Skip to content

Move mime-type collection generation to a function that can be tested… #54844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matiasbenedetto merged 6 commits into from
Sep 27, 2023
Merged

Move mime-type collection generation to a function that can be tested… #54844

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
53f19dd
Move mime-type collection generation to a function that can be tested…
pbking Sep 26, 2023
e49d739
linting changes
pbking Sep 26, 2023
f0830e0
Add unit tests to mime type getter
pbking Sep 27, 2023
a5c7a1f
Fixed linting errors
pbking Sep 27, 2023
e780f81
test the entire output array and replace assertTrue by assertEquals
matiasbenedetto Sep 27, 2023
49d2c04
fixing docs
matiasbenedetto Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add unit tests to mime type getter
  • Loading branch information
@pbking
pbking committed Sep 27, 2023
commit f0830e09c61069a88ff806b9187de060e04e37d3
85 changes: 85 additions & 0 deletions phpunit/tests/fonts/font-library/wpFontLibrary/getMimeTypes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
<?php
/**
* Test WP_Font_Family_Utils::get_expected_font_mime_types_per_php_version().
*
* @package WordPress
* @subpackage Font Library
*
* @group fonts
* @group font-library
*
* @covers WP_Font_Family_Utils::get_expected_font_mime_types_per_php_version
*/
class Tests_Fonts_WpFontsFamilyUtils_GetMimeTypes extends WP_UnitTestCase {

/**
*
* @dataProvider data_should_supply_correct_mime_type_for_php_version
*
* @param array $php_version Font file path.

*/
public function test_should_supply_correct_mime_type_for_php_version( $php_info ) {

$mime_types = WP_Font_Library::get_expected_font_mime_types_per_php_version( $php_info[ 'php_version_id' ] );

$this->assertTrue( $mime_types['otf'] === $php_info['otf'] );
$this->assertTrue( $mime_types['ttf'] === $php_info['ttf'] );
$this->assertTrue( $mime_types['woff'] === $php_info['woff'] );
$this->assertTrue( $mime_types['woff2'] === $php_info['woff2'] );
}

/**
* Data provider.
*
* @return array[]
*/
public function data_should_supply_correct_mime_type_for_php_version() {
return array(array(
'version 7.2' => array(
'php_version_id' => 70200,
'otf' => 'font/otf',
'ttf' => 'application/x-font-ttf',
'woff' => 'application/font-woff',
'woff2' => 'application/font-woff2'
),
'version 7.3' => array(
'php_version_id' => 70300,
'otf' => 'font/otf',
'ttf' => 'application/font-sfnt',
'woff' => 'application/font-woff',
'woff2' => 'application/font-woff2'
),
'version 7.4' => array(
'php_version_id' => 70400,
'otf' => 'font/otf',
'ttf' => 'font/sfnt',
'woff' => 'application/font-woff',
'woff2' => 'application/font-woff2'
),
'version 8.0' => array(
'php_version_id' => 80000,
'otf' => 'font/otf',
'ttf' => 'font/sfnt',
'woff' => 'application/font-woff',
'woff2' => 'application/font-woff2'
),
'version 8.1' => array(
'php_version_id' => 80100,
'otf' => 'font/otf',
'ttf' => 'font/sfnt',
'woff' => 'font/woff',
'woff2' => 'font/woff2'
),
'version 8.2' => array(
'php_version_id' => 80200,
'otf' => 'font/otf',
'ttf' => 'font/sfnt',
'woff' => 'font/woff',
'woff2' => 'font/woff2'
),
));

}

}