Skip to content

Font Library: add read and write permission checks based on rest api type #54859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
madhusudhand wants to merge 1 commit into from
Closed

Font Library: add read and write permission checks based on rest api type #54859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 43 additions & 11 deletions lib/experimental/fonts/font-library/class-wp-rest-font-library-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public function register_routes() {
array(
'methods' => WP_REST_Server::EDITABLE,
'callback' => array( $this, 'install_fonts' ),
'permission_callback' => array( $this, 'update_font_library_permissions_check' ),
'permission_callback' => array( $this, 'check_font_library_permissions_write' ),
'args' => array(
'fontFamilies' => array(
'required' => true,
Expand All @@ -62,7 +62,7 @@ public function register_routes() {
array(
'methods' => WP_REST_Server::DELETABLE,
'callback' => array( $this, 'uninstall_fonts' ),
'permission_callback' => array( $this, 'update_font_library_permissions_check' ),
'permission_callback' => array( $this, 'check_font_library_permissions_write' ),
'args' => $this->uninstall_schema(),
),
)
Expand All @@ -75,7 +75,7 @@ public function register_routes() {
array(
'methods' => WP_REST_Server::READABLE,
'callback' => array( $this, 'get_font_collections' ),
'permission_callback' => array( $this, 'update_font_library_permissions_check' ),
'permission_callback' => array( $this, 'check_font_library_permissions_read' ),
),
)
);
Expand All @@ -87,7 +87,7 @@ public function register_routes() {
array(
'methods' => WP_REST_Server::READABLE,
'callback' => array( $this, 'get_font_collection' ),
'permission_callback' => array( $this, 'update_font_library_permissions_check' ),
'permission_callback' => array( $this, 'check_font_library_permissions_read' ),
),
)
);
Expand Down Expand Up @@ -305,13 +305,34 @@ public function uninstall_fonts( $request ) {
}

/**
* Checks whether the user has permissions to update the Font Library.
* Checks whether the user has read permission to the Font Library.
*
* @since 6.4.0
*
* @return true|WP_Error True if the request has read access, WP_Error object otherwise.
*/
public function check_font_library_permissions_read( $request ) {
if( current_user_can('editor') || current_user_can('administrator') || current_user_can('author') ) {
return true;
}

return new WP_Error(
'rest_cannot_read_font_library',
__( 'Sorry, you are not allowed to read the Font Library on this site.', 'gutenberg' ),
array(
'status' => rest_authorization_required_code(),
)
);
}

/**
* Checks whether the user has write permissions to the Font Library.
*
* @since 6.4.0
*
* @return true|WP_Error True if the request has write access for the item, WP_Error object otherwise.
*/
public function update_font_library_permissions_check() {
public function check_font_library_permissions_write( $request ) {
if ( ! current_user_can( 'edit_theme_options' ) ) {
return new WP_Error(
'rest_cannot_update_font_library',
Expand All @@ -322,13 +343,24 @@ public function update_font_library_permissions_check() {
);
}

// check if request has assets to write or delete.
$fonts_param = $request->get_param( 'fontFamilies' );
$fonts_to_install = json_decode( $fonts_param, true );
$method = $request->get_method();

if ( 'POST' === $method ) {
// check if files are present.
} elseif ( 'DELETE' === $method ) {

}

// The update endpoints requires write access to the temp and the fonts directories.
$temp_dir = get_temp_dir();
$upload_dir = wp_upload_dir()['basedir'];
if ( ! is_writable( $temp_dir ) || ! wp_is_writable( $upload_dir ) ) {
$temp_dir = get_temp_dir();
$fonts_dir = WP_Font_Library::get_fonts_dir();
if ( ! is_writable( $temp_dir ) || ! wp_is_writable( $fonts_dir ) ) {
return new WP_Error(
'rest_cannot_write_fonts_folder',
__( 'Error: WordPress does not have permission to write the fonts folder on your server.', 'gutenberg' ),
'rest_cannot_write_to_fonts_dir',
__( 'Error: WordPress does not have write permission for the fonts directory on the server.', 'gutenberg' ),
array(
'status' => 500,
)
Expand Down