Skip to content

Use list role instead of listbox in patterns list #54884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevin940726 merged 1 commit into from
Sep 28, 2023
Merged

Use list role instead of listbox in patterns list #54884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/edit-site/src/components/page-patterns/grid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default function Grid( { categoryId, items, ...props } ) {
}

return (
<ul role="listbox" className="edit-site-patterns__grid" { ...props }>
<ul className="edit-site-patterns__grid" { ...props }>
{ items.map( ( item ) => (
<GridItem
key={ item.name }
Expand Down
17 changes: 9 additions & 8 deletions test/e2e/specs/site-editor/patterns.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,27 +88,28 @@ test.describe( 'Patterns', () => {

await expect(
navigation.getByRole( 'button', { name: 'All patterns' } )
).toBeVisible();
).toContainText( '1' );
await expect(
navigation.getByRole( 'button', { name: 'My patterns' } )
).toBeVisible();
).toContainText( '1' );
await expect(
navigation.getByRole( 'button', { name: 'Uncategorized' } )
).toBeVisible();
).toContainText( '1' );

await expect(
patternsContent.getByRole( 'heading', {
name: 'All patterns',
level: 2,
} )
).toBeVisible();
const patternsList = patternsContent.getByRole( 'list', {
name: 'All patterns',
} );
await expect( patternsList.getByRole( 'listitem' ) ).toHaveCount( 1 );
await expect(
patternsContent
.getByRole( 'listbox', { name: 'All patterns' } )
// TODO: should be `getByRole( 'option', { name: 'My pattern' } )`
patternsList
.getByRole( 'heading', { name: 'My pattern' } )
.getByRole( 'button', { name: 'My pattern', exact: true } )
// TODO: Shouldn't need this.
.nth( 0 )
).toBeVisible();
} );
} );