Skip to content

Patterns: Add category selector to pattern creation modal #55024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronrobertshaw merged 17 commits into from
Oct 9, 2023
Merged

Patterns: Add category selector to pattern creation modal #55024

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3cd8056
Add category selector to pattern creation modal
glendaviesnz Oct 3, 2023
cffbb95
Switch to adding categories to the form token suggestion list
glendaviesnz Oct 4, 2023
bb764fe
tidy up variable naming
glendaviesnz Oct 4, 2023
774ade4
Make sure the slugs used in taxonomy match those used in core pattern…
glendaviesnz Oct 4, 2023
376efef
Get categories from core store
glendaviesnz Oct 4, 2023
ee676d6
Fix label
glendaviesnz Oct 4, 2023
232772a
Simplify the merging of the categories.
glendaviesnz Oct 4, 2023
3945d70
Explain removal of the query slug category
glendaviesnz Oct 4, 2023
3817dbe
fix comment typo
glendaviesnz Oct 4, 2023
18c49a4
Switch to using a map instead of an array for storing categories
glendaviesnz Oct 5, 2023
01bca09
switch to map has instead of get
glendaviesnz Oct 5, 2023
a200196
Use a forEach instead of a reduce
glendaviesnz Oct 5, 2023
7815d52
Fix typo
glendaviesnz Oct 5, 2023
29865fb
Remove unneeded fallback array
glendaviesnz Oct 5, 2023
ba3c8e1
Remove redundant `true` prop values
glendaviesnz Oct 5, 2023
906df26
Fix dynamic height and width when adding new categories
kevin940726 Oct 6, 2023
862078f
Fix suggestions list width
kevin940726 Oct 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo
  • Loading branch information
@glendaviesnz
glendaviesnz committed Oct 5, 2023
commit 7815d52b01c0ccc761191613ad0fa8edb0b4b1b5
2 changes: 1 addition & 1 deletion packages/patterns/src/components/create-pattern-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export default function CreatePatternModal( {
( category ) => {
if (
! uniqueCategories.has( category.label ) &&
// There are two core categories with `Post` label so explictily remove the one with
// There are two core categories with `Post` label so explicitly remove the one with
// the `query` slug to avoid any confusion.
category.name !== 'query'
) {
Expand Down