Skip to content

Tabs: Fix flaky unit tests #55950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chad1008 merged 2 commits into from
Nov 17, 2023
Merged

Tabs: Fix flaky unit tests #55950

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61ba416
fix flaky unit tests
chad1008 Nov 7, 2023
1a2ba5d
add notes refering to this PR
chad1008 Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/components/src/tabs/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,15 @@ describe( 'Tabs', () => {
await screen.findByRole( 'tab', { name: 'Alpha' } )
).toHaveFocus();

// This assertion ensures the component has had time to fully
// render, preventing flakiness.
// see https://github.com/WordPress/gutenberg/pull/55950
await waitFor( () =>
expect(
screen.getByRole( 'tab', { name: 'Beta' } )
).toHaveAttribute( 'tabindex', '-1' )
);

// Because all other tabs should have `tabindex=-1`, pressing Tab
// should NOT move the focus to the next tab, which is Beta.
// Instead, focus should go to the currently selected tabpanel (alpha).
Expand Down Expand Up @@ -847,6 +856,16 @@ describe( 'Tabs', () => {
// onSelect should not be called since the disabled tab is
// highlighted, but not selected.
await user.keyboard( '[Tab]' );

// This assertion ensures focus has time to move to the first
// tab before the test proceeds, preventing flakiness.
// see https://github.com/WordPress/gutenberg/pull/55950
await waitFor( () =>
expect(
screen.getByRole( 'tab', { name: 'Alpha' } )
).toHaveFocus()
);

await user.keyboard( '[ArrowLeft]' );
expect( mockOnSelect ).toHaveBeenCalledTimes( 1 );

Expand Down