Skip to content

Fix the image link button pressed state. #56123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afercia merged 2 commits into from
Nov 16, 2023
Merged

Fix the image link button pressed state. #56123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48c4e6d
Fix image link button pressed state.
afercia Nov 14, 2023
621a99b
Add changelog entry.
afercia Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/block-editor/src/components/url-popover/image-url-input-ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ const ImageURLInputUI = ( {
aria-expanded={ isOpen }
onClick={ openLinkUI }
ref={ setPopoverAnchor }
isActive={ !! url }
/>
{ isOpen && (
<URLPopover
Expand Down
4 changes: 4 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Bug Fix

- `Toolbar`: Remove CSS rule that prevented focus outline to be visible for toolbar buttons in the `:active` state. ([#56123](https://github.com/WordPress/gutenberg/pull/56123)).

### Internal

- Migrate `Divider` from `reakit` to `ariakit` ([#55622](https://github.com/WordPress/gutenberg/pull/55622))
Expand Down
5 changes: 0 additions & 5 deletions packages/components/src/toolbar/toolbar-button/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@
bottom: 10px;
}

// Hide focus rectangle on click.
&:active::before {
display: none;
}

&:not(:disabled).is-pressed[data-subscript]::after {
color: $white;
}
Expand Down