Skip to content

Font Library: run wp_font_family post content sanitization using wp_insert_post_data filter #56172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matiasbenedetto wants to merge 21 commits into from
Closed

Font Library: run wp_font_family post content sanitization using wp_insert_post_data filter #56172

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
364bfb2
run wp_font_family post content sanitization using a filter
matiasbenedetto Nov 15, 2023
30168a6
format php
matiasbenedetto Nov 16, 2023
04fe84e
format php
matiasbenedetto Nov 16, 2023
1a9fc03
function redeclaration guard
matiasbenedetto Nov 16, 2023
8c54bff
using the unsanitized data as an input to the sanitation function fol…
matiasbenedetto Nov 16, 2023
617064c
format php
matiasbenedetto Nov 16, 2023
eb4a6a0
run wp_font_family post content sanitization using a filter
matiasbenedetto Nov 15, 2023
11a3270
format php
matiasbenedetto Nov 16, 2023
9fd6c9c
format php
matiasbenedetto Nov 16, 2023
eab4f52
function redeclaration guard
matiasbenedetto Nov 16, 2023
bfb2187
using the unsanitized data as an input to the sanitation function fol…
matiasbenedetto Nov 16, 2023
498978a
format php
matiasbenedetto Nov 16, 2023
6d42863
Do not reference $this.
jffng Dec 13, 2023
b97d6de
Handle json decoding and encoding.
jffng Dec 13, 2023
3bbd4f3
Update test.
jffng Dec 13, 2023
a4baa78
Update lib/experimental/fonts/font-library/class-wp-font-family-utils…
jffng Dec 14, 2023
46b7758
Restore to previous version of test.
jffng Dec 14, 2023
832db93
Add guards and checks.
jffng Dec 14, 2023
122b193
Format php.
jffng Dec 14, 2023
a98a087
Merge branch 'fix/sanitize-font-family-post-content' of github.com:Wo…
matiasbenedetto Dec 14, 2023
770c5b5
fix merge
matiasbenedetto Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format php
  • Loading branch information
@matiasbenedetto
matiasbenedetto committed Nov 16, 2023
commit 30168a6356235e6451ce950947d36221c2450e74
13 changes: 6 additions & 7 deletions lib/experimental/fonts/font-library/font-library.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,19 +59,19 @@ function wp_register_font_collection( $config ) {

/*
* Sanitize font family content
*
*
* @param array $data An array of slashed, sanitized, and processed post data.
* @param array $postarr An array of sanitized (and slashed) but otherwise unmodified post data.
*
*
* @return array The post data that will be inserted in the database.
*/
function sanitize_font_family_content( $data, $postarr ) {
// Check if the post type is 'wp_font_family'
if ( isset( $postarr['post_type'] ) && $postarr['post_type'] === 'wp_font_family' ) {
if ( isset( $postarr['post_type'] ) && $postarr['post_type'] === 'wp_font_family' ) {
$result = WP_Font_Family_Utils::sanitize( $data['post_content'] );
}
// Return the (possibly modified) data
return $data;
}
// Return the (possibly modified) data
return $data;
}

add_filter( 'wp_insert_post_data', 'sanitize_font_family_content', 10, 2 );
Expand All @@ -85,4 +85,3 @@ function sanitize_font_family_content( $data, $postarr ) {
);

wp_register_font_collection( $default_font_collection );